-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/cd rt sout net cdf #66
Conversation
@@ -62,7 +67,7 @@ MODULE CRTM_RTSolution_Define | |||
PUBLIC :: CRTM_RTSolution_InquireFile | |||
PUBLIC :: CRTM_RTSolution_ReadFile | |||
PUBLIC :: CRTM_RTSolution_WriteFile | |||
|
|||
PUBLIC :: CRTM_RTSolution_WriteFile_netCDF |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
writefile_netcdf should live within CRTM_RTSolution_WriteFile -- you could pass an optional flag for it to determine if it's netCDF or not. I would not at all be against just defaulting to netCDF as the standard output format and removing the binary option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can do that. Currently the CRTM_RTSolution_WriteFile
is build as Binary output interface only. Let me try to modify it.
@@ -110,6 +115,71 @@ MODULE CRTM_RTSolution_Define | |||
! File status on close after write error | |||
CHARACTER(*), PARAMETER :: WRITE_ERROR_STATUS = 'DELETE' | |||
|
|||
! Output netCDF attributes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How are these being used?
@@ -134,7 +204,7 @@ MODULE CRTM_RTSolution_Define | |||
! Forward radiative transfer intermediate results for a single channel | |||
! These components are not defined when they are used as TL, AD | |||
! and K variables | |||
REAL(fp) :: SSA_Max = ZERO ! Max Single Scattering Albedo in the profile | |||
REAL(fp) :: SSA_Max = ZERO ! Max Single Scattering Albedo in the profile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this used for?
! Radiative transfer results for a single channel | ||
REAL(fp) :: Radiance = ZERO | ||
REAL(fp) :: Brightness_Temperature = ZERO | ||
REAL(fp) :: Stokes(4) | ||
REAL(fp) :: Stokes(4) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are the contents of this?
…s in either Binary or NetCDF format
Updated |
@BenjaminTJohnson This branch is ready for merge for netCDF output only. We should perhaps discuss more on the ctests related updates, see #72. All ctests passed but occasionally the channel subset test fails: |
Description
This PR add new module to write CRTM output RTS into netCDF format:
CRTM_RTSolution_WriteFile_netCDF
CRTMv3/src/RTSolution/CRTM_RTSolution_Define.f90
Line 1223 in 6cd0398
To use
CRTM_RTSolution_WriteFile_netCDF
, uncomment code block incheck_crtm.f90
:CRTMv3/src/Build/libsrc/test/check_crtm.F90
Line 393 in 6cd0398
There is no code changes to
src/RTSolution/Common_RTSolution.f90
, but a lot of auto space deletion due to code editor.Issue(s) addressed
#62
Dependencies
None
Impact
None