Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cd v241 sfc emis #51

Merged
merged 9 commits into from
Aug 25, 2023
Merged

Conversation

chengdang
Copy link
Contributor

@chengdang chengdang commented Jul 18, 2023

This PR merges v2.4.1 surface emissivity updates into v3, major updates including:

  • NetCDF I/O for all surface emissivity LUTs (except for MW water)
  • Interface required for new IR emissivity tables: Nalli2.IRwater, Nalli.IRsnow and Nalli2.IRsnow
  • Fix folder: (1) all IR water emissivity tables need to be updated for this branch to work; (2) new optional table Nalli2.IRsnow needs to be added to fix folder.
  • All standalone CRTM ctests passed.

This branch contains all updates that is currently in develop branch and feature/cd_v241_cloud_aerosol_io

This PR should be merged after PR #37 ; can be merged after PR #39.

@BenjaminTJohnson
Copy link
Contributor

@chengdang can you resolve the conflict here, and verify that the provided coefficient tarball has the necessary files?

@chengdang
Copy link
Contributor Author

@BenjaminTJohnson Conflict resolved.

Yes, you are right. The current tarball fix_REL-3.0.0_20230303.tgz does not have the updated files.
It needs to be updated:

@chengdang
Copy link
Contributor Author

Tarball is updated and uploaded to pub/s4/CRTM: fix_REL-3.0.0_20230802.tgz
Modified Get_CRTM_Binary_Files.sh.

I'm a bit confused about the version number (?) 9cf4b1cc57e20802e608a597d7f53073 CMakeFile.txt here: https://github.com/JCSDA/CRTMv3/blob/0cb4259fb7ece671ff65eb7ca65c159f1d1227fd/test/CMakeLists.txt#L82C87-L82C119, so I did not upload anything to pub/s4/CRTM/file/

@BenjaminTJohnson
Copy link
Contributor

@chengdang I will test / merge this today. Sorry for the long delay.

…proper location (previously it was being put into fix/fix/, rather than fix/
… rather than the ftp://ftp.ssec.wisc.edu/ URL (both work, just being more consistent)
@BenjaminTJohnson
Copy link
Contributor

@chengdang I created PRs in the UFO and fv3-jedi internal repository to reflect the changes in the coefficients files and the update of the tarball name and md5sum values. As they're approved in UFO and fv3-jedi, merge this PR, then give them the go ahead to merge theirs.

@chengdang
Copy link
Contributor Author

@BenjaminTJohnson I uploaded file crtm_coefficients_3.0.0_skylab_6.0.tar.gz.md5 to the s4 ftp site, per instruction by @fabiolrdiniz. This file is needed for UFO/FV3/MPAS-JEDI tests

@fabiolrdiniz fabiolrdiniz added the coordinate merge Ready for merge but needs to be coordinated with other repos label Aug 22, 2023
@BenjaminTJohnson BenjaminTJohnson merged commit df92574 into develop Aug 25, 2023
@chengdang chengdang deleted the feature/cd_v241_sfc_emis branch January 24, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
coordinate merge Ready for merge but needs to be coordinated with other repos CRTM CRTM enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New IR snow emissivity table: Nalli2.IRsnow.EmisCoeff.nc4 Merge CRTM 2.4.1 surface updates into CRTM v3
3 participants