Feature/cd air craft star #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @chengdang, thank you for including me in the review! Is there documentation available from the author for the changes, a report maybe that goes into the math details, so that we can trace back the implementation? |
|
Hi @StegmannJCSDA~ welcome back! There was no implementation documentation available specifically for this feature. My reference is this book chapter: "Liu and Lu, 2016, Community Radiative Transfer Model for Air Quality Studies, Equation 16(a-b)". In this code branch, I added some notes to the equations (this will ideally be merged after we merge this PR), you may use this as a reference for code review: CRTMv3/src/RTSolution/ADA/ADA_Module.f90 Line 99 in 1a8cd44 |
|
Cheng and Patrick,
I prepared the attached document about ADA in the CRTM. Please help to
archive the document to the JCSDA github. Please review the document and
ADA_Module.f90, whether the document and the code are clear and agree.
Thanks,
Mark
…On Wed, Oct 30, 2024 at 2:18 PM Cheng Dang ***@***.***> wrote:
Hi @StegmannJCSDA <https://github.com/StegmannJCSDA>~ welcome back!
There was no implementation documentation available specifically for this
feature. My reference is this book chapter: "Liu and Lu, 2016, Community
Radiative Transfer Model for Air Quality Studies, Equation 16(a-b)".
Please let us know if there is any more references @quanhualiu
<https://github.com/quanhualiu>, thank you!
In this code branch, I added some notes to the equations (this will
ideally be merged after we merge this PR), you may use this as a reference
for code review:
https://github.com/JCSDA/CRTMv3/blob/1a8cd44c77ad480701193fba3637379c42d6546a/src/RTSolution/ADA/ADA_Module.f90#L99
—
Reply to this email directly, view it on GitHub
<#179 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQCRLPDRQU5E67JWJCPRMKTZ6EPHHAVCNFSM6AAAAABNXLA5OSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBXHE4TGMBWGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
[image: image.png]
On Thu, Oct 31, 2024 at 12:07 PM Quanhua (Mark) Liu <
***@***.***> wrote:
… Cheng and Patrick, <br> <br> I prepared the attached document about ADA in
the CRTM. Please help to <br> archive the document to the JCSDA github.
Please review the document and <br> ADA_Module.f90, whether the document
and the code are clear and agree. <br> <br> Thanks, <br> Mark <br> <br> On
Wed, Oct 30, 2024 at 2:18 PM Cheng Dang ***@***.***> wrote: <br> <br>
> Hi @StegmannJCSDA <https://github.com/StegmannJCSDA>~ welcome
back! <br> > <br> > There was no implementation documentation
available specifically for this <br> > feature. My reference is this
book chapter: "Liu and Lu, 2016, Community <br> > Radiative
Transfer Model for Air Quality Studies, Equation 16(a-b)". <br> >
Please let us know if there is any more references @quanhualiu <br> >
<https://github.com/quanhualiu>, thank you! <br> > <br> > In
this code branch, I added some notes to the equations (this will <br> >
ideally be merged after we merge this PR), you may use this as a reference
<br> > for code review: <br> >
https://github.com/JCSDA/CRTMv3/blob/1a8cd44c77ad480701193fba3637379c42d6546a/src/RTSolution/ADA/ADA_Module.f90#L99
<br> > <br> > — <br> > Reply to this email directly, view it on
GitHub <br> > <
#179 (comment)>, or
<br> > unsubscribe <br> > <
https://github.com/notifications/unsubscribe-auth/AQCRLPDRQU5E67JWJCPRMKTZ6EPHHAVCNFSM6AAAAABNXLA5OSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBXHE4TGMBWGI>
<br> > . <br> > You are receiving this because you were
mentioned.Message ID: <br> > ***@***.***> <br> > <br>
—
Reply to this email directly, view it on GitHub
<#179 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMP5X4LQWE2UPG5ATNYH6DTZ6JIVJAVCNFSM6AAAAABNXLA5OSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJQGI3DEMBVGI>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
The added notes for codes in ADA_Module.f90 are right and very helpful. I approve the changes. |
|
@BenjaminTJohnson if it looks good to you, I'll go ahead and merge this PR. |
BenjaminTJohnson
approved these changes
Nov 25, 2024
|
@chengdang go ahead and merge if you're ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains some of the recent updates to CRTM delivered by STAR https://github.com/JCSDA/CRTMv3/tree/CloudRadar_AirCraft, including:
Notes:
Dependencies
None
Impact
Expect changes to CRTM forward results at aircraft level
More scientific validation is needed.
Checklist