Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for CRTM standalone configuration files #161

Closed
wants to merge 1 commit into from

Conversation

chengdang
Copy link
Contributor

@chengdang chengdang commented Aug 12, 2024

Update for CRTM standalone configuration files, which may be needed for offline standalone packages or tests.

src/Build/configure is generated automatically by autogen.sh

These updates do not necessarily need to be included in the released v3.1.1 branch.

Note
Note that the previously noted error, introduced by active sensor calculation insrc/Build/libsrc/test/check_crtm is still unresolved (gfortran, macOS). See issue https://github.com/JCSDA-internal/crtm/issues/435, https://github.com/JCSDA-internal/crtm/issues/410, will revisit this later:

/Library/Developer/CommandLineTools/usr/bin/ranlib: file: libcrtm.a(Fundamental_Constants.o) has no symbols
cd libsrc && /Library/Developer/CommandLineTools/usr/bin/make check
cd test && /Library/Developer/CommandLineTools/usr/bin/make check
gfortran -I.. -fconvert=big-endian -fbounds-check -mieee-fp -fimplicit-none -ffpe-trap=overflow,zero,invalid -ffree-form -fno-second-underscore -frecord-marker=4 -ggdb -fopenmp -Wall -Wconversion -std=f2008 -c   -lcrtm   -L /usr/local/Cellar/netcdf/4.9.2_1/lib -lnetcdf   -L /usr/local/Cellar/netcdf-fortran/4.6.1/lib -lnetcdff   -L /usr/local/Cellar/hdf5/1.14.3_1/lib -lhdf5   -I /usr/local/Cellar/netcdf/4.9.2_1/include   -I /usr/local/Cellar/netcdf-fortran/4.6.1/include   -I /usr/local/Cellar/hdf5/1.14.3_1/include  check_crtm.F90
check_crtm.F90:325:7:

  325 |        rts_K%Reflectivity(m) = ZERO
      |       1
Error: Component to the right of a part reference with nonzero rank must not have the ALLOCATABLE attribute at (1)
check_crtm.F90:326:7:

  326 |        rts_K%Reflectivity_Attenuated(m) = ZERO
      |       1
Error: Component to the right of a part reference with nonzero rank must not have the ALLOCATABLE attribute at (1)
make[2]: *** [check_crtm.o] Error 1
make[1]: *** [check] Error 2
make: *** [check] Error 2

  *********************
  crtm_rebuild.sh(ERROR): Error checking the CRTM library build
  *********************

@BenjaminTJohnson
Copy link
Contributor

@chengdang REL-3.1.1. removed all of these files. We no longer support the autotools / configure method of building CRTM. If you let me know which tests / configurations still use these, I can provide a CMake update to support them.

@chengdang chengdang closed this Aug 28, 2024
@BenjaminTJohnson BenjaminTJohnson deleted the feature/cd_standalone_config branch August 29, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants