-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix user emissivity AD #155
fix user emissivity AD #155
Conversation
…mmon_RTSolution.f90 per Mark Liu suggestion for user defined emissivity adjoint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you!
@chengdang I want to write a ctest for this, so I will do one more update with the test before merging. |
The change has been tested and I approved it.
…On Wed, Aug 7, 2024 at 3:13 PM Cheng Dang ***@***.***> wrote:
***@***.**** approved this pull request.
Looks good! Thank you!
—
Reply to this email directly, view it on GitHub
<#155 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQCRLPFMVYP3GYBSCXCQJ63ZQJWT7AVCNFSM6AAAAABME5B5JWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMRVHE4TINRQGI>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
…_matrix (test_User_Emissivity)
@chengdang would you mind testing again with the new ctests? |
@BenjaminTJohnson Sorry that I missed the earlier message. Testing it now. |
All tests passed! Thanks Ben.
|
For user specified surface emissivity and scattering cases, the surface emissivity jacobian can be corrected by changing one line code:
From
User_Emissivity_AD = ZERO
to
User_Emissivity_AD = sum(SfcOptics_AD%Emissivity(1:nZ,1))
Closes: #152