Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix user emissivity AD #155

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

BenjaminTJohnson
Copy link
Contributor

For user specified surface emissivity and scattering cases, the surface emissivity jacobian can be corrected by changing one line code:
From
User_Emissivity_AD = ZERO
to
User_Emissivity_AD = sum(SfcOptics_AD%Emissivity(1:nZ,1))

Closes: #152

…mmon_RTSolution.f90 per Mark Liu suggestion for user defined emissivity adjoint.
Copy link
Contributor

@chengdang chengdang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@BenjaminTJohnson
Copy link
Contributor Author

@chengdang I want to write a ctest for this, so I will do one more update with the test before merging.

@quanhualiu
Copy link

quanhualiu commented Aug 7, 2024 via email

@BenjaminTJohnson
Copy link
Contributor Author

@chengdang would you mind testing again with the new ctests? test_User_Emissivity* Thanks!

@BenjaminTJohnson BenjaminTJohnson merged commit 0e58776 into develop Aug 8, 2024
@BenjaminTJohnson BenjaminTJohnson deleted the bugfix/btj_user_emissivity_fix_for_v311 branch August 8, 2024 18:06
@chengdang
Copy link
Contributor

@BenjaminTJohnson Sorry that I missed the earlier message. Testing it now.

@chengdang
Copy link
Contributor

chengdang commented Aug 8, 2024

All tests passed! Thanks Ben.

        Start  55: test_forward_User_Emissivity_atms_n21
 55/178 Test  #55: test_forward_User_Emissivity_atms_n21 ............   Passed    0.45 sec
        Start  56: test_forward_User_Emissivity_cris-fsr_n21
 56/178 Test  #56: test_forward_User_Emissivity_cris-fsr_n21 ........   Passed    0.36 sec
        Start  57: test_forward_User_Emissivity_v.abi_g18
 57/178 Test  #57: test_forward_User_Emissivity_v.abi_g18 ...........   Passed    0.06 sec
        Start  58: test_forward_User_Emissivity_atms_npp
 58/178 Test  #58: test_forward_User_Emissivity_atms_npp ............   Passed    0.02 sec
        Start  59: test_forward_User_Emissivity_cris399_npp
 59/178 Test  #59: test_forward_User_Emissivity_cris399_npp .........   Passed    0.10 sec
        Start  60: test_forward_User_Emissivity_v.abi_gr
 60/178 Test  #60: test_forward_User_Emissivity_v.abi_gr ............   Passed    0.06 sec
        Start  61: test_forward_User_Emissivity_abi_g18
 61/178 Test  #61: test_forward_User_Emissivity_abi_g18 .............   Passed    0.03 sec
        Start  62: test_forward_User_Emissivity_modis_aqua
 62/178 Test  #62: test_forward_User_Emissivity_modis_aqua ..........   Passed    0.03 sec
...

100% tests passed, 0 tests failed out of 178

Label Time Summary:
CRTM_Tests    = 185.87 sec*proc (178 tests)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

verify surface emissivity jacobian in cloudy conditions across spectrum
3 participants