Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment out alert messages with Invalid WMO Satellite Id #118

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

chengdang
Copy link
Contributor

Description

This PR removes the alert messages when the satellite id is an invalid WMO id.

For now some of the sensor IDs are set as INVALID_WMO_SATELLITE_ID in SensorInfo/CRTM_SensorInfo.f90 and perhaps during instrument coefficient generation. CRTM simulations for these sensors will log extensive warning messages from calling function CRTM_SensorData_IsValid (see issue #96), which is probably unnecessary.

This PR provides an temporary fix, and should be reconsidered if in the future:

  • a valid WMO_SATELLITE_ID (from CRTM instrument coefficients) is required elsewhere in the DA system.
  • a sensor must have a valid WMO_SATELLITE_ID for CRTM to support it.

Issue(s) addressed

#96
#50

@chengdang chengdang self-assigned this Mar 19, 2024
@BenjaminTJohnson BenjaminTJohnson merged commit 5471d95 into develop Mar 20, 2024
@BenjaminTJohnson BenjaminTJohnson deleted the hotfix/cd_log_InvalidWMOSensor branch March 20, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants