Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SABER blocks chaining for training #852

Merged
merged 4 commits into from
Apr 19, 2023

Conversation

benjaminmenetrier
Copy link
Contributor

@shlyaeva shlyaeva requested a review from travissluka April 18, 2023 15:43
@shlyaeva
Copy link
Contributor

@travissluka note that the plan is to merge this PR tomorrow morning. I think changes in ewok B matrix experiment yamls may be required (minimal, similar to changes in test yamls), and may affect soca-science as well.

@benjaminmenetrier
Copy link
Contributor Author

This PR can be merged now.

@travissluka travissluka merged commit 5d1a7ad into develop Apr 19, 2023
@travissluka travissluka deleted the feature/saber_blocks_for_training branch April 19, 2023 15:51
travissluka pushed a commit that referenced this pull request Apr 25, 2023
climbfuji added a commit that referenced this pull request Jul 17, 2023
* Use SABER blocks chaining for training (#852)

* Adapt to name changes in ufo (#867)

* Use VertInterp instead of MarineVertInterp (#874)

* remove linear var change from ensevariance ctest (#881)

* Bugfixes for BUMP (#869)

* A few fixes to the Model to Analysis variable change (#847)

* Remove discontinuities in the balance op  (#885)

* set to min/max instead of 0

* ...

* vanilla vert conv

* tidy sign

* removed jac_mask

* tanh filt

* updated yamls and test refs

* merge develop and update answers after the develop history MESS i created

* code tidy/removed vanilla

---------

Co-authored-by: Travis Sluka <[email protected]>

* default plots (#888)

Co-authored-by: Travis Sluka <[email protected]>

* add VADER to SOCA (#887)

* add vader to build, but dont use it

* add State::fromFieldSet

* variablechange "uses" vader

* switched to ens. templ. (#894)

* Implementation of EnsMeanAndVariance (#892)

* added the ensmeanandvariance app

* ...

---------

Co-authored-by: Travis Sluka <[email protected]>

* Read the std. dev. instead of the variance (#896)

* skip sqrt, saving optional

* forgot test yaml

* Update test/testinput/varchange_bkgerrsoca_stddev.yml

Co-authored-by: Travis Sluka <[email protected]>

---------

Co-authored-by: Travis Sluka <[email protected]>

* Use the generic oops interpolator (#898)

* use oops interpolation

* to_fieldset_ad

* forgot some halo masks

* fix horizfilt

* fix some test answers

* letkf workaround for missing val bug

* work around for getvalues test

* change obs input to have 1 guaranteed land point

* Update version (#899)

* remove ewok repo (#889)

Co-authored-by: Yannick Trémolet <[email protected]>

* Merge B matrix-related applications (#890)

* Merge B matrix-related applications

* Trigger tests

---------

Co-authored-by: Benjamin Menetrier <[email protected]>
Co-authored-by: Travis Sluka <[email protected]>

* update for VADER PR#586 (#902)

* add ModelData

* fix coding norms

* Update CMakeLists.txt

* Fix vertical gradient (#914)

* a fix dvdz

* Updating test references

---------

Co-authored-by: Hyun-Chul.Lee <[email protected]>

* libs in soca

* Commend out dirac.x test and disable ecbuild_install_project as we did for fv3-jedi prevent the following error:

-- Configuring done
CMake Error in soca/src/soca/CMakeLists.txt:
  Target "soca" INTERFACE_LINK_DIRECTORIES property contains path:

    "/Users/heinzell/work/ufs-bundle/20230714/ufs-bundle-use-jedi-develop/soca/src/soca/."

  which is prefixed in the source directory.

-- Generating done
CMake Generate step failed.  Build files cannot be regenerated correctly.

* Apply same bug fix as for fv3-jedi to fix missing linker path for MPI libraries due to ESMF bug

---------

Co-authored-by: Benjamin Menetrier <[email protected]>
Co-authored-by: Wojciech Śmigaj <[email protected]>
Co-authored-by: Travis Sluka <[email protected]>
Co-authored-by: Guillaume Vernieres <[email protected]>
Co-authored-by: Yannick Trémolet <[email protected]>
Co-authored-by: Benjamin Menetrier <[email protected]>
Co-authored-by: Kriti Bhargava <[email protected]>
Co-authored-by: Hyun-Chul.Lee <[email protected]>
Co-authored-by: Dom Heinzeller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants