fix: type error in the tests and tests failing

JCMais · Dec 25, 2024 · 728ed68 · 728ed68
1 parent 4d1967b
commit 728ed68
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 4 deletions.
diff --git a/scripts/ci/build.sh b/scripts/ci/build.sh
@@ -403,8 +403,10 @@ else
   ldd ./lib/binding/node_libcurl.node || true
 fi
 
+sleep 1
 echo "Showing /etc/hosts"
 cat /etc/hosts || true
+sleep 1
 
 if [ "$RUN_TESTS" == "true" ]; then
   if [ -n "$ELECTRON_VERSION" ]; then

diff --git a/test/curl/callbacks.spec.ts b/test/curl/callbacks.spec.ts
@@ -4,8 +4,6 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  */
-import 'should'
-
 import { createServer } from '../helper/server'
 import { Curl, CurlCode } from '../../lib'
 import { CurlPreReqFunc } from '../../lib/enum/CurlPreReqFunc'

diff --git a/test/helper/commonOptions.ts b/test/helper/commonOptions.ts
@@ -12,7 +12,7 @@ export function withCommonTestOptions(curl: Curl | Easy | Record<string, any>) {
       curl.setOpt(key, value)
     })
   } else {
-    Object.assign(curl, options)
+    Object.assign(options, curl)
   }
 
   return options

diff --git a/test/helper/server.ts b/test/helper/server.ts
@@ -27,7 +27,6 @@ export const createApp = () => {
   app
     .use(express.urlencoded({ extended: true }))
     .use(express.raw({ limit: '100MB', type: 'application/node-libcurl.raw' }))
-    // @ts-expect-error - no time for fixing this right now
     .use(cookieParser())
 
   app.disable('etag')