Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Side by side diff shows empty diff #58

Closed
vendeeglobe opened this issue Aug 5, 2020 · 4 comments
Closed

Side by side diff shows empty diff #58

vendeeglobe opened this issue Aug 5, 2020 · 4 comments
Labels

Comments

@vendeeglobe
Copy link

Using php-diff version 2.2.0. In my use case this happens when I use pipes for the table syntax. Looks like a line break issue to me.

inline_diff
side-by-side_diff

version_a.txt
version_b.txt

@DigiLive DigiLive added the bug label Aug 5, 2020
@DigiLive
Copy link
Collaborator

DigiLive commented Aug 5, 2020

Can you please confirm commit 369b146 resolves the issue?
The output is like previous versions and as expected?

@vendeeglobe
Copy link
Author

vendeeglobe commented Aug 5, 2020

Patch tested and it works.
side-by-side_diff_patched

I closed the issue unintentionally.

@DigiLive
Copy link
Collaborator

DigiLive commented Aug 5, 2020

Thank you for the feedback.
We'll release an update asap.

@JBlond I think a part of the code was removed due merging a pr. However, I'm not sure. Maybe we must consider a branching model to minimize these errors.

DigiLive pushed a commit that referenced this issue Aug 5, 2020
- Reverted used sample texts.
@DigiLive DigiLive mentioned this issue Aug 5, 2020
@JBlond JBlond closed this as completed in 02695d5 Aug 6, 2020
@JBlond
Copy link
Owner

JBlond commented Aug 6, 2020

@vendeeglobe The new release is there with the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants