Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Add dev requirement for issue 50. #51

Merged
merged 1 commit into from
Nov 14, 2016
Merged

BUG: Add dev requirement for issue 50. #51

merged 1 commit into from
Nov 14, 2016

Conversation

binarysubstrate
Copy link
Contributor

Fixes #50

@coveralls
Copy link

coveralls commented Nov 14, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.3%) to 89.691% when pulling 280aa0a on binarysubstrate:issue_50 into 6ffc60e on JBKahn:master.

4 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 89.691% when pulling 280aa0a on binarysubstrate:issue_50 into 6ffc60e on JBKahn:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 89.691% when pulling 280aa0a on binarysubstrate:issue_50 into 6ffc60e on JBKahn:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 89.691% when pulling 280aa0a on binarysubstrate:issue_50 into 6ffc60e on JBKahn:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 89.691% when pulling 280aa0a on binarysubstrate:issue_50 into 6ffc60e on JBKahn:master.

@JBKahn
Copy link
Owner

JBKahn commented Nov 14, 2016 •
edited
Loading

LGTM, the error is because of the Django 1.0.3 bug as referenced in the #48 which was patched in Django 1.10.4 (unreleased)

@JBKahn JBKahn merged commit a6b82b7 into JBKahn:master Nov 14, 2016
@JBKahn
Copy link
Owner

JBKahn commented Nov 14, 2016

Thanks for the PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@binarysubstrate @coveralls @JBKahn