Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't initialize Compare with list of features #117

Closed
jpweytjens opened this issue Sep 25, 2019 · 0 comments
Closed

Can't initialize Compare with list of features #117

jpweytjens opened this issue Sep 25, 2019 · 0 comments

Comments

@jpweytjens
Copy link
Contributor

jpweytjens commented Sep 25, 2019

When a Compare class is initialized with a list of features, the returned class has no features. This is caused by the following lines in base.py

def __init__(self, features=[], n_jobs=1, indexing_type='label',
                 **kwargs):

    self.features = []
    self.add(features)

    # public
    if n_jobs == -1:
        self.n_jobs = cpu_count()
    else:
        self.n_jobs = n_jobs

    self.indexing_type = indexing_type  # label of position
    self.features = []

The features are added to self.features, but later removed again. I will write a small PR to fix this issue.

jpweytjens pushed a commit to jpweytjens/recordlinkage that referenced this issue Nov 28, 2019
jpweytjens pushed a commit to jpweytjens/recordlinkage that referenced this issue Nov 28, 2019
@J535D165 J535D165 closed this as completed Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants