little fixes #2
Merged
little fixes #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Markus Rathgeb <[email protected]>
J-N-K
pushed a commit
that referenced
this pull request
Mar 14, 2019
Signed-off-by: Markus Rathgeb <[email protected]>
J-N-K
added a commit
that referenced
this pull request
Aug 30, 2019
Signed-off-by: Jan N. Klug <[email protected]>
J-N-K
pushed a commit
that referenced
this pull request
Jun 20, 2020
Added new functions for the binding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I rebased your branch to the current master, made my fixes and dropped the rebase again.
So, you need to rebase your branch after this one gets merged and all tests should succeed.
All classes that ends with "Test" are treated as JUnit tests.
If there are no tests in such an class this can result into an error.
There is an abstract base class that name ends with "Test" but it does not contain a test.
There are two options, rename the class that it does not match the pattern or add an ignore annotation to the class.
I changed the name of class.