Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add legacyMode to use rtm.connect #300

Merged
merged 2 commits into from
Oct 3, 2022
Merged

Add legacyMode to use rtm.connect #300

merged 2 commits into from
Oct 3, 2022

Conversation

nhaquet2
Copy link

rtm.connect used instead of app connection
following deprecation of rtm.start

legacyMode is the default mode

Change-Id: I5b38877986ec952cf7abdc1a2cd1befe3cdafe1e

Nicolas Haquet added 2 commits September 30, 2022 17:41
rtm.connect used instead of app connection
following deprecation of rtm.start

legacyMode is the default mode

Change-Id: I5b38877986ec952cf7abdc1a2cd1befe3cdafe1e
Fix SlackSessionFactoryBuilder with legacyMode
Fix nullpointer when sending messages with no attachments

Change-Id: I83f86790b2794753878bb3603555c9f7cee506b8
@bcorne bcorne merged commit 75e6e16 into Itiviti:master Oct 3, 2022
@FranciscoRuiz-FT
Copy link

FranciscoRuiz-FT commented Oct 4, 2022

Hello @bcorne / @josselinchevalay, thank you very much for bringing these changes in, will they be released to any specific library version (I mean maven central)? Sorry, I'm not very familiar with the lifecycle 😊

@tanu3195
Copy link

tanu3195 commented Oct 4, 2022

rtm.connect used instead of app connection following deprecation of rtm.start

legacyMode is the default mode

Change-Id: I5b38877986ec952cf7abdc1a2cd1befe3cdafe1e

Hi All,

We are using the below image so do we have any updated image at docker hub with the latest changes?

outofcoffee/corebot-generic:1.3.0

Regards,

@bcorne
Copy link
Contributor

bcorne commented Oct 4, 2022

Hello @bcorne / @josselinchevalay, thank you very much for bringing these changes in, will they be released to any specific library version (I mean maven central)? Sorry, I'm not very familiar with the lifecycle 😊

Hello @FranciscoRuiz-FT

We've just done the release. It should be available soon on maven central

Best regards,

Benoit

@josselinchevalay
Copy link

Hello @tanu3195,

We are not the maintainer of the image outofcoffee/corebot-generic what we have just done and release 1.4.0 I invite you to approach to make an issue so that it upgrades the version of simplelackapi and republish an updated docker image on their project : https://github.com/outofcoffee/corebot/issues

Regards

@tanu3195
Copy link

tanu3195 commented Oct 5, 2022

@josselinchevalay Thanks for the reply.

I have opened the issue there 7 days back but let me update along with recommendations above.

outofcoffee/corebot#61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants