Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Session.connect failure #5

Closed
gsingers opened this issue Mar 26, 2015 · 2 comments
Closed

Session.connect failure #5

gsingers opened this issue Mar 26, 2015 · 2 comments

Comments

@gsingers
Copy link

If the Slack session fails to connect, for instance due to a bad auth token, there is no way to know if you have a valid session or not. It appears the connect() method silently swallows all exceptions. It would be better to throw them so that we can fail early.
@bcorne
Copy link
Contributor

bcorne commented Mar 27, 2015

yes, I'll fix that for the next version, thanks for the feedback

bcorne pushed a commit that referenced this issue Mar 27, 2015
addressing issue #5
c26f036 
Change-Id: I47403b58d2283107bb364d52cde50d192d80b2cc
bcorne pushed a commit that referenced this issue Mar 27, 2015
addressing issue #5
9f02bd1 
Change-Id: I47403b58d2283107bb364d52cde50d192d80b2cc
@bcorne
Copy link
Contributor

bcorne commented Mar 27, 2015

I've commit a small change to throw the error on connect() failure.

@bcorne bcorne closed this as completed Mar 27, 2015
bcorne pushed a commit that referenced this issue Jan 6, 2022
@moults31
Merge pull request #5 from moults31/moults31/issue284-invalid-param
a991483 
Fix #284 - Update param user->users in conversations.invite
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gsingers @bcorne