Skip to content

Commit

Permalink
[bug_fix] Missing resource from OpenShift Routes prevents them to be …
Browse files Browse the repository at this point in the history
…deployed in OpenShift clusters (open-telemetry#1337)

* Add missing resource for OpenShift routes

Signed-off-by: Israel Blancas <[email protected]>

* Add missing file

Signed-off-by: Israel Blancas <[email protected]>

* Add missing changelog file

Signed-off-by: Israel Blancas <[email protected]>

Signed-off-by: Israel Blancas <[email protected]>
  • Loading branch information
iblancasa authored Jan 10, 2023
1 parent fecd51d commit 137b13e
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 1 deletion.
16 changes: 16 additions & 0 deletions .chloggen/1337-fix-routes-openshift.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: bug_fix

# The name of the component, or a single word describing the area of concern, (e.g. operator, target allocator, github action)
component: operator

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: "There was a missing resource in the OpenShift routes ClusterBinding"

# One or more tracking issues related to the change
issues: [1337]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,7 @@ spec:
- route.openshift.io
resources:
- routes
- routes/custom-host
verbs:
- create
- delete
Expand Down
1 change: 1 addition & 0 deletions config/rbac/role.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,7 @@ rules:
- route.openshift.io
resources:
- routes
- routes/custom-host
verbs:
- create
- delete
Expand Down
2 changes: 1 addition & 1 deletion controllers/opentelemetrycollector_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ func NewReconciler(p Params) *OpenTelemetryCollectorReconciler {
// +kubebuilder:rbac:groups=opentelemetry.io,resources=opentelemetrycollectors/status,verbs=get;update;patch
// +kubebuilder:rbac:groups=opentelemetry.io,resources=opentelemetrycollectors/finalizers,verbs=get;update;patch
// +kubebuilder:rbac:groups=networking.k8s.io,resources=ingresses,verbs=get;list;watch;create;update;patch;delete
// +kubebuilder:rbac:groups=route.openshift.io,resources=routes,verbs=get;list;watch;create;update;patch;delete
// +kubebuilder:rbac:groups=route.openshift.io,resources=routes;routes/custom-host,verbs=get;list;watch;create;update;patch;delete
// +kubebuilder:rbac:groups=coordination.k8s.io,resources=leases,verbs=get;list;create;update
// +kubebuilder:rbac:groups="",resources=events,verbs=create;patch

Expand Down

0 comments on commit 137b13e

Please sign in to comment.