Skip to content

Commit

Permalink
Refactor Reconciliation Flow (open-telemetry#1995)
Browse files Browse the repository at this point in the history
* save

* bump

* 🤷

* should b good

* change delete logic

* change error comparison

* gomod

* Working status

* remove cruft

* fix selector check for deepequals

* add controller references

* Fix lint and test

* facepalm

* Record field

* Fix diffing bug

* Add lots of tests

* Remove old logic entirely

* dont forget the kube builder

* update comment, reusable builder

* respond to feedback

* update based on feedback

* update comments, remove method that does nothing

* naming
  • Loading branch information
jaronoff97 authored Sep 20, 2023
1 parent b84b893 commit 0632c69
Show file tree
Hide file tree
Showing 44 changed files with 2,019 additions and 3,672 deletions.
16 changes: 16 additions & 0 deletions .chloggen/reconcile-change.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: enhancement

# The name of the component, or a single word describing the area of concern, (e.g. operator, target allocator, github action)
component: operator

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Introduces a new method of reconciliation to reduce duplication and complexity

# One or more tracking issues related to the change
issues: [1959]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:
50 changes: 3 additions & 47 deletions bundle/manifests/opentelemetry-operator.clusterserviceversion.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,8 @@ spec:
- ""
resources:
- configmaps
- serviceaccounts
- services
verbs:
- create
- delete
Expand All @@ -132,46 +134,12 @@ spec:
verbs:
- list
- watch
- apiGroups:
- ""
resources:
- serviceaccounts
verbs:
- create
- delete
- get
- list
- patch
- update
- watch
- apiGroups:
- ""
resources:
- services
verbs:
- create
- delete
- get
- list
- patch
- update
- watch
- apiGroups:
- apps
resources:
- daemonsets
verbs:
- create
- delete
- get
- list
- patch
- update
- watch
- apiGroups:
- apps
resources:
- deployments
- statefulsets
verbs:
- create
- delete
Expand All @@ -188,18 +156,6 @@ spec:
- get
- list
- watch
- apiGroups:
- apps
resources:
- statefulsets
verbs:
- create
- delete
- get
- list
- patch
- update
- watch
- apiGroups:
- autoscaling
resources:
Expand Down
50 changes: 3 additions & 47 deletions config/rbac/role.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ rules:
- ""
resources:
- configmaps
- serviceaccounts
- services
verbs:
- create
- delete
Expand All @@ -30,46 +32,12 @@ rules:
verbs:
- list
- watch
- apiGroups:
- ""
resources:
- serviceaccounts
verbs:
- create
- delete
- get
- list
- patch
- update
- watch
- apiGroups:
- ""
resources:
- services
verbs:
- create
- delete
- get
- list
- patch
- update
- watch
- apiGroups:
- apps
resources:
- daemonsets
verbs:
- create
- delete
- get
- list
- patch
- update
- watch
- apiGroups:
- apps
resources:
- deployments
- statefulsets
verbs:
- create
- delete
Expand All @@ -86,18 +54,6 @@ rules:
- get
- list
- watch
- apiGroups:
- apps
resources:
- statefulsets
verbs:
- create
- delete
- get
- list
- patch
- update
- watch
- apiGroups:
- autoscaling
resources:
Expand Down
Loading

0 comments on commit 0632c69

Please sign in to comment.