Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default url handler #996

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

mauriziopinotti
Copy link
Contributor

URL is not passed correctly to handler if it contains special chars.

Example failing url: https://mcas-proxyweb.mcas.ms/certificate-checker?login=false&originalUrl=https%3A%2F%2Fstatics.teams.cdn.office.net.mcas.ms...

In the case above the url handler only receives https://mcas-proxyweb.mcas.ms/certificate-checker?login=false (the url is cut after "&").

@jijojosephk
Copy link
Collaborator

Thanks @mauriziopinotti for your contribution. Next time please update com.github.IsmaelMartinez.teams_for_linux.appdata.xml as well with version updates along with package.json. I'll merge it now and update the changes myself. Many thanks again!

@jijojosephk jijojosephk merged commit af4d9e4 into IsmaelMartinez:develop Oct 30, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants