Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: error when opening links #1300

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Fix: error when opening links #1300

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions app/mainAppWindow/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,12 @@ exports.onAppReady = async function onAppReady(configGroup) {
});

window = await browserWindowManager.createWindow();
if (iconChooser) {

if (iconChooser) {
const m = new Menus(window, configGroup, iconChooser.getFile());
m.onSpellCheckerLanguageChanged = onSpellCheckerLanguageChanged;
}

addEventHandlers();

login.handleLoginDialogTry(window, {'ssoBasicAuthUser': config.ssoBasicAuthUser, 'ssoBasicAuthPasswordCommand': config.ssoBasicAuthPasswordCommand});
Expand Down Expand Up @@ -296,7 +296,7 @@ function onBeforeSendHeadersHandler(detail, callback) {
}

function onNewWindow(details) {
logger.debug(`testing RegExp onNewWindow ${new RegExp(config.meetupJoinRegEx).test(arg)}`);
logger.debug(`testing RegExp onNewWindow ${new RegExp(config.meetupJoinRegEx).test(details.url)}`);
if (new RegExp(config.meetupJoinRegEx).test(details.url)) {
logger.debug('DEBUG - captured meetup-join url');
return { action: 'deny' };
Expand Down Expand Up @@ -360,7 +360,7 @@ function getWebRequestFilterFromURL() {
if (intune) {
intune.setupUrlFilter(filter);
}

return filter;
}

Expand Down
Loading