Allow to disable notification sounds from the UI

[victornoel]

Describe the bug

I've disabled notification sound in the preferences:

But I am still hearing them (for chat messages, mentions, etc), it does "ding" every time, it's really annoying :P

I saw that there was this flag disableNotificationSound but I don't understand why we can't just disable it from the UI (because sometimes I would like to enable it.

Feature Proposal

Add an entry in the option menu to switch the value of disableNotificationSound directly from the UI.

Desktop (please complete the following information):

• OS: archlinux
• Installation package [deb, rpm, snap, AppImage, tar.gz, source...]: https://aur.archlinux.org/packages/teams-for-linux
• Version: 1.3.11

[IsmaelMartinez]

Hi @victornoel ,

The notifications you get, the annoying ones, is a different implementation. In most configurations the MS notifications do not work, or only partly works.

Can you see if you can enable the MS ones and use the disableNotificationSound and see if you get the desired result?

We could add the disableNotificationSound to the options menu, so you people can disable them without needing a restart. If that is the desired option, then we can change this to a feature request and it should be easy to implement.

Let me know and I can put some pointers in here.

[victornoel]

Can you see if you can enable the MS ones and use the disableNotificationSound and see if you get the desired result?

So if I leave the MS ones disabled and add disableNotificationSound=true, then I don't get those "ding" noise everytime someone send me a message.

If I then enable the MS ones, it does not change anything, I don't get any sound either.

We could add the disableNotificationSound to the options menu, so you people can disable them without needing a restart. If that is the desired option, then we can change this to a feature request and it should be easy to implement.

This would be good enough for me ^^ too bad we can't just rely on the MS configuration, but I guess it's not as easy as it can seem :P

Thanks!

[IsmaelMartinez]

If you can change it to a feature (for the feature flag) someone might pick it up. I might look into it in the future, but don't know when. I can point you in the right direction if you're interested

[victornoel]

@IsmaelMartinez cool, I edited the description and title, I hope it's good enough to make it obvious that it's a feature request and to understand what needs to be done :)

[dxps]

Same ”annoyance” that I'd like to get rid of.

Is there something I can do to remove that "ding" sound, please ❓
That disableNotificationSound=true can be set somewhere (for example, in ~/.var/app/com.github.IsmaelMartinez.teams_for_linux/config/teams-for-linux/Preferences file) ❔

Thanks!

[dxps]

I really like this desktop app, but unfortunately that sound is very disturbing, especially when you're in a meeting and that background sound that we cannot control (whether to turn it off or its volume, as shown below) is getting very loud.

Talking about controlling its volume, if this app would be available here, that would still help.

Unfortunately, for now, unless there is a workaround, I have to stop using it and go back to that official PWA. 😢

[IsmaelMartinez]

At the moment you can only disable that sound notification using the disableNotificationSound option in the command line. Adding that to the options menu is not to complex. I don't remember where it is but I encourage anyone to open a PR. Happy to review it, otherwise I will see when I can have a look at it.

…

On Mon, 15 Jan 2024, 08:29 Marius Ileana, ***@***.***> wrote: I really like this desktop app, but unfortunately that sound is very disturbing, especially when you're in a meeting and that background sound that we cannot control (whether to turn it off or its volume, as shown below) is getting very loud. Talking about controlling its volume, if this app would be available here, that would still help. image.png (view on web) <https://github.com/IsmaelMartinez/teams-for-linux/assets/14140226/8849d830-be97-45e6-a702-3558dc3634c3> Unfortunately, for now, unless there is a workaround, I have to stop using it and go back to that official PWA. 😢 — Reply to this email directly, view it on GitHub <#959 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADJHECB7TTNAMKN33YMHQDYOTSFNAVCNFSM6AAAAAA5CVEY6KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJRGU2TGOBSHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[dxps]

@IsmaelMartinez Thanks for the feedback! 🙏

I'm back and happy using it again. 🤗

Added --disableNotificationSound as a startup flag:

❯ cat /usr/share/applications/teams-for-linux.desktop
[Desktop Entry]
Name=Teams for Linux
Exec=/opt/teams-for-linux/teams-for-linux --disableNotificationSound %U
Terminal=false
Type=Application
Icon=teams-for-linux
StartupWMClass=teams-for-linux
Comment=Unofficial Microsoft Teams client for Linux using Electron. It uses the Web App and wraps it as a standalone application using Electron.
MimeType=x-scheme-handler/msteams;
Categories=Chat;Network;Office;
❯ 

[IsmaelMartinez]

Added a PR to see if those notifications can be disabled via the UI. If anyone can check it by getting that branch and running yarn start that would be great.

[dxps]

@IsmaelMartinez That's great! Thanks! 🙏

Started it (from feature/959-notifications-menu-options branch), and I'm planning to use it today, the whole day.
I'll get back with the feedback about the sound.

Meanwhile, would you mind clarifying what Disable sound (if not available) means?
And by Disable Flash you mean disable the notification popup, right?

[IsmaelMartinez]

From the config options:

• disableNotificationSoundIfNotAvailable: 'Disables notification sound unless status is Available (e.g. while in a call, busy, etc.)
• disableNotificationWindowFlash: 'A flag indicates whether to disable window flashing when there is a notification'

I haven't implemented nor use either, but hopefully this is working. I got mine running just now but waiting for calls/meetings

[dxps]

Ah, so that not available refers to the user status. Maybe a more specific description helps, such as Disable sound when I'm not available (ex: busy, in a call).

It's still unclear to me what's that flashing effect you're referring to, but that's ok.

Used it for the whole day, and I'm glad that I got no sound at all.
Therefore, from my point of view, it's totally fine to merge this change and generate a new release.

And once again, thanks a lot for the feedback and help! 🙏

[IsmaelMartinez]

The flashFrame is this. https://www.electronjs.org/docs/latest/api/browser-window#winflashframeflag

Basically if you got a new unread message/notification, the window will flash.

I have changed the descriptions a wee bit

[IsmaelMartinez]

Released under https://github.com/IsmaelMartinez/teams-for-linux/releases/tag/v1.4.5

[hosswald]

@IsmaelMartinez

The flashFrame is this. https://www.electronjs.org/docs/latest/api/browser-window#winflashframeflag

Basically if you got a new unread message/notification, the window will flash.

I have changed the descriptions a wee bit

The quick setting boxes don't work for me (Linux Mint 21.3 Cinnamon, I tried the apt version 1.4.12 as well as flatpak 1.4.10). Clicking them has no effect, the settings remain off.
What works is enabling the settings (only tried for the flatpak version) via /home/username/.var/app/com.github.IsmaelMartinez.teams_for_linux/config/teams-for-linux/config.json
They then show as enabled in the taskbar menu, but can't be disabled there.