Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to see what is been shared #83

Closed
IsmaelMartinez opened this issue Mar 25, 2019 · 2 comments
Closed

Ability to see what is been shared #83

IsmaelMartinez opened this issue Mar 25, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@IsmaelMartinez
Copy link
Owner

It will be great to be able to see what it is sharing.

Similar to what Skype does (small view in the corner).

Technically that requires the following:

  1. Under https://github.com/IsmaelMartinez/teams-for-linux/tree/master/app/browser/desktopShare , create a new child view similar to the captureSelector.html. That will have a video tag for the video to stream to.
  2. Modify the https://github.com/IsmaelMartinez/teams-for-linux/blob/master/app/browser/desktopShare/chromeApi.js#L9 to also stream the video to the page created in point 1. An example can be found in the desktop-capturer electron page https://electronjs.org/docs/api/desktop-capturer

Note, it might be needed to modify the captureSelector to also return the source type (desktop/screen).

@IsmaelMartinez IsmaelMartinez added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Mar 25, 2019
@IsmaelMartinez IsmaelMartinez changed the title Show what is been shared Ability to show what is been shared Mar 25, 2019
@IsmaelMartinez IsmaelMartinez removed good first issue Good for newcomers help wanted Extra attention is needed labels Mar 26, 2019
@IsmaelMartinez IsmaelMartinez self-assigned this Mar 26, 2019
@IsmaelMartinez
Copy link
Owner Author

I will be picking this one up tomorrow.

@IsmaelMartinez IsmaelMartinez changed the title Ability to show what is been shared Ability to see what is been shared Mar 27, 2019
@IsmaelMartinez
Copy link
Owner Author

PR created. It does the basic. A couple of corner cases not handled at the moment (see the pr for more info).

I will not really have much time now for a couple of weeks, but wanted to push it up here as this might be an indirect fix for #61 .

I create this in a branch called feature/83

IsmaelMartinez added a commit that referenced this issue Apr 1, 2019
Initial WIP for adding an extra screen to show what we are sharing #83
@IsmaelMartinez IsmaelMartinez mentioned this issue Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant