Option for SSO Login Popups for certain Apps

[elhennig]

I tried to add an app to my teams client that will ask for "Login with Company SSO". In the MS client this will open a popup to continue to login, while the request in teams-for-linux will go to the default browser and not return to the app.

Is there any option to handle such requests (i.e. URLs) within the client?

[elhennig]

The error message from debugging is

(electron) The new-window event is deprecated and will be removed. Please use contents.setWindowOpenHandler() instead.

[IsmaelMartinez]

Can you try doing Ctrl + Click? if it opens a separate pop up on the browser you then log in on a different context, what might be causing the problem.

[elhennig]

I did, and it behaves the same way as without CTRL: It only opens a window in my default browser. However, it seems that for this one app in Teams the authentication will not work outside the teams client's context.

[IsmaelMartinez]

This piece of logic is the one that will be determining to open it into a different screen.

https://github.com/IsmaelMartinez/teams-for-linux/blob/develop/app/mainAppWindow/index.js#L188

MS do change how the handle the pop ups every now and then... so maybe they have changed something.

[elhennig]

For me it looks like the request to login via SSO goes to my browser but the return stays there and does not come back to the teams client.

[IsmaelMartinez]

Might be related to the PWA issue with the links. I think MS changed something. There is an open issue that might help. Let me find it.

[IsmaelMartinez]

#675 might be related to this.

[IsmaelMartinez]

The PR in #713 might fix this issue.

[IsmaelMartinez]

pre-release in https://github.com/IsmaelMartinez/teams-for-linux/releases/tag/v1.0.56

[elhennig]

The behavior in 1.0.56 is still the same as before, unfortunately

[jijojosephk]

Can you tell me which app you're trying to add? Let me try to reproduce at my end

[elhennig]

The app is Office RND Hybrid (see https://www.officernd.com)

[jijojosephk]

Thanks but it's asking for some admin rights. What I get.

1. start free trial
2. launches a new window
3. then i have admin rights error.

The above is restriction on my account.

So what is the expectation if everything's right.

[elhennig]

Well this is a app to book work places in our company. It tries to open a page with a SSO page (from the MS cloud, probably at some point this leads to login.microsoftonline.com) and opens it in a browser but looses the context and does not revert back to Teams-for-Linux. In the MS Teams Web-App this feedback returns well, of course.

[jijojosephk]

Do you face the same with GitHub also? Something like this

[IsmaelMartinez]

Have you tried doing a ctlr+click on the app? That should open it in the same context so the credentials cab be used.

…

On Sat, 29 Apr 2023, 15:11 Jijo Joseph, ***@***.***> wrote: Do you face the same with GitHub also? Something like this [image: image] <https://user-images.githubusercontent.com/11662148/235307299-a41b5b39-a884-4032-b854-2999013e7229.png> — Reply to this email directly, view it on GitHub <#695 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADJHEGD73TJSA4E44CEV6TXDUORJANCNFSM6AAAAAAVOPYQWE> . You are receiving this because you commented.Message ID: ***@***.***>

[jijojosephk]

@IsmaelMartinez it's not currently implemented. CTRL + click is having disposition background-tab that is currently denied. We should show a confirmation before sharing the session.

[jijojosephk]

@elhennig checkout 1.0.78

[elhennig]

@jijojosephk Thanks a lot! The new dialogue works fine for me (tried with 1.0.80).

[foxylion]

Hey, after updating to the latest version I noticed the change made here. While this might be sometimes useful it is pretty bad UX for users that do not need this regularly. I can now no longer open links with a single click, but do need two clicks and a mouse movement. When trying to open multiple links in a row this does not take ages...