Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compatibility to include Drupal 10. #49

Merged
merged 3 commits into from
Jun 22, 2023
Merged

Update compatibility to include Drupal 10. #49

merged 3 commits into from
Jun 22, 2023

Conversation

rosiel
Copy link
Member

@rosiel rosiel commented Jun 13, 2023

GitHub Issue: (link)

Islandora/documentation#2235

What does this Pull Request do?

Makes Openseadragon Drupal 10 compatible.

What's new?

A in-depth description of the changes made by this PR. Technical details and
possible side effects.

  • Changes x feature to such that y
  • Added x
  • Removed y
  • Does this change require documentation to be updated?
  • Does this change add any new dependencies?
  • Does this change require any other modifications to be made to the repository
    (i.e. Regeneration activity, etc.)?
  • Could this change impact execution of existing code?

How should this be tested?

Install on Drupal 10 and give it an external Mirador URI.

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/committers

Copy link
Contributor

@alxp alxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small notice when running PHPUnit tests:

Testing /Users/alexanderoneill/Sites/d10/web/modules/contrib/openseadragon/tests
..... 5 / 5 (100%)

Time: 00:05.333, Memory: 8.00 MB

OK (5 tests, 40 assertions)

Remaining self deprecation notices (5)

5x: The Drupal\Tests\openseadragon\Kernel\IIIFManifestParserTest::$modules property must be declared protected. See https://www.drupal.org/node/2909426
5x in DrupalListener::startTest from Drupal\Tests\Listeners

Alexanders-MBP:core alexanderoneill$

@rosiel
Copy link
Member Author

rosiel commented Jun 21, 2023

i'll add D10 to the testing matrix first

@rosiel
Copy link
Member Author

rosiel commented Jun 21, 2023

or after. whoops.

@rosiel rosiel requested a review from alxp June 21, 2023 18:10
@rosiel
Copy link
Member Author

rosiel commented Jun 21, 2023

I think that update c357901) should cover the deprecation notices you saw. The tests ran and I don't see any deprecation warnings in them now.

@alxp alxp merged commit 862d653 into 2.x Jun 22, 2023
@alxp alxp deleted the drupal10 branch June 22, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants