Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add drupal/core JS dependency for anon user view. #35

Merged
merged 1 commit into from
Mar 31, 2021

Conversation

alxp
Copy link
Contributor

@alxp alxp commented Mar 30, 2021

GitHub Issue: OpenSeadragon viewer does not display for Anonymous on Drupal 9

What does this Pull Request do?

Out of the box Drupal 9, the OpenSeadragon viewer is not shown when viewing an Image object as Anonymous.

What's new?

Drupal 9 does not include the drupal/core JS library by default for anonymous users. This PR adds this dependency.

How should this be tested?

From a fresh install on Drupal 9:

  1. Apply the patch and clear the Drupal cache.
  2. Create a Repository Object and select Image for the Model and Resource Type, and OpenSeadragon for the display hint.
  3. Add a Media of type Image.
  4. Log out and view the object. The OpenSeadragon viewer should appear where it did not before.

Interested parties

Fix by @ppound

@Islandora/8-x-committers,

Copy link
Contributor

@seth-shaw-unlv seth-shaw-unlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised. 👍

@seth-shaw-unlv seth-shaw-unlv merged commit 0fd1218 into 8.x-1.x Mar 31, 2021
@seth-shaw-unlv seth-shaw-unlv deleted the d9_anon_fix branch March 31, 2021 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants