Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error during Batch Ingests of Compound Children before parent objects #157

Merged
merged 5 commits into from
May 7, 2019
Merged

Error during Batch Ingests of Compound Children before parent objects #157

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1e8e301
set parent to null if parent doesnt exist
IAMlKeno Apr 11, 2019
0e63e1d
kill the process if the parent does not exist
IAMlKeno Apr 11, 2019
9947337
better handling of parent not existing
IAMlKeno Apr 11, 2019
6c2acaf
Avoid creating fake object for missing parent object
IAMlKeno Apr 23, 2019
00ad628
Allow PHP 5.3.3 to fail
IAMlKeno May 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions islandora_compound_object.module
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -739,7 +739,7 @@ function islandora_compound_object_retrieve_compound_info(AbstractObject $object
$next_pid = (isset($siblings[$current_key + 1])) ? $siblings[$current_key + 1] : '';

// Check if perms to show link for parent manage.
if (islandora_object_manage_access_callback(array(
if ($parent && islandora_object_manage_access_callback(array(
ISLANDORA_METADATA_EDIT, ISLANDORA_MANAGE_PROPERTIES, ISLANDORA_ADD_DS), $parent)) {
$parent_url = 'islandora/object/' . $parent_pid . '/manage';
}
Expand All @@ -748,7 +748,7 @@ function islandora_compound_object_retrieve_compound_info(AbstractObject $object
}

$info = array(
'parent_label' => $parent->label,
'parent_label' => ($parent && $parent->label) ? $parent->label : NULL,
DiegoPino marked this conversation as resolved.
Show resolved Hide resolved
'parent_pid' => $parent_pid,
'parent_url' => $parent_url,
'previous_pid' => $previous_pid,
Expand Down