Fix incorrect path in Permissions helptext #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joecorall Do you have write access? If you can add a review, we can merge this. |
|
@bondjimbond - no I do not. I am not in the committers group. @DonRichards asked that I add a review to this PR in the tech call yesterday after I mentioned the PR looked good to me. |
|
Dang; maybe @DonRichards can approve? |
noahwsmith
approved these changes
Jan 18, 2024
|
Need a +1 from someone in @Islandora/legacy-committers |
DonRichards
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request do?
Help text on the Permissions page links to a nonexistent path to configure roles that can manage embargoed objects. This PR points that link to the right place.
What's new?
Formerly, the help text pointed to
/admin/islandora/solution_pack_config/embargo/roles, which goes nowhere. This PR changes that path to/admin/islandora/tools/embargo/roles.How should this be tested?
No testing required.
Interested parties
@Islandora/7-x-1-x-committers