Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for Mysql 8.0 #7

Merged
merged 1 commit into from
Jan 12, 2022
Merged

Conversation

whikloj
Copy link
Member

@whikloj whikloj commented Dec 17, 2021

The GRANT ALL PRIVILEGES ON .... TO .... IDENTIFIED BY ... has been deprecated, you now must create the user first then grant permissions.

This just splits it up in multiple commands and works in MySQL 5.7 as well as 8.

@kstapelfeldt
Copy link
Member

Question in tech call of how to test this - do we just need to observe that it still works when the testing pipeline goes?

@whikloj
Copy link
Member Author

whikloj commented Jan 10, 2022

That is probably the easiest way as this repository is only used for our testing matrix.

@kstapelfeldt kstapelfeldt requested a review from alxp January 12, 2022 18:53
@alxp alxp merged commit 3a2c098 into Islandora:github-actions Jan 12, 2022
@whikloj whikloj deleted the fix-things branch January 12, 2022 19:07
@whikloj
Copy link
Member Author

whikloj commented Jan 12, 2022

Thanks @alxp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants