Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Test matrix: remove php7.3, mysql5.7. #886

Merged
merged 19 commits into from
Jul 27, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
97 changes: 8 additions & 89 deletions .github/workflows/build-2.x.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,96 +19,19 @@ jobs:
build:
# The type of runner that the job will run on
runs-on: ubuntu-latest
continue-on-error: ${{ matrix.allowed_failure }}
strategy:
fail-fast: false
matrix:
php-versions: ["7.3", "7.4"]
# PHP 8.1 fails - see https://github.com/Islandora/islandora/issues/887
php-versions: ["7.4", "8.0"]
# test-suite functional-javascript will appear to pass but will skip tests; missing chromedriver.
test-suite: ["kernel", "functional", "functional-javascript"]
drupal-version: ["9.3.x", "9.4.x-dev"]
# Not yet Drupal 10 ready - see https://github.com/Islandora/islandora/issues/888
drupal-version: ["9.3.x", "9.4.x", "9.5.x-dev"]
mysql: ["8.0"]
allowed_failure: [false]
mysql: ["5.7"]
# include experimental parts
include:
# 9.3.x on PHP 8.0
- drupal-version: '9.3.x'
php-versions: '8.0'
mysql: "8.0"
test-suite: "kernel"
allowed_failure: true
- drupal-version: '9.3.x'
php-versions: '8.0'
mysql: "8.0"
test-suite: "functional"
allowed_failure: true
- drupal-version: '9.3.x'
php-versions: '8.0'
mysql: "8.0"
test-suite: "functional-javascript"
allowed_failure: true
# 9.3.x on PHP 8.1
- drupal-version: '9.3.x'
php-versions: '8.1'
mysql: "8.0"
test-suite: "kernel"
allowed_failure: true
- drupal-version: '9.3.x'
php-versions: '8.1'
mysql: "8.0"
test-suite: "functional"
allowed_failure: true
- drupal-version: '9.3.x'
php-versions: '8.1'
mysql: "8.0"
test-suite: "functional-javascript"
allowed_failure: true
# 9.4.x-dev on PHP "8.0"
- drupal-version: '9.4.x-dev'
php-versions: '8.0'
mysql: "8.0"
test-suite: "kernel"
allowed_failure: true
- drupal-version: '9.4.x-dev'
php-versions: '8.0'
mysql: "8.0"
test-suite: "functional"
allowed_failure: true
- drupal-version: '9.4.x-dev'
php-versions: '8.0'
mysql: "8.0"
test-suite: "functional-javascript"
allowed_failure: true
# 9.4.x-dev on PHP 8.1
- drupal-version: '9.4.x-dev'
php-versions: '8.1'
mysql: "8.0"
test-suite: "kernel"
allowed_failure: true
- drupal-version: '9.4.x-dev'
php-versions: '8.1'
mysql: "8.0"
test-suite: "functional"
allowed_failure: true
- drupal-version: '9.4.x-dev'
php-versions: '8.1'
mysql: "8.0"
test-suite: "functional-javascript"
allowed_failure: true
# 10.0.x-dev on PHP 8.1
- drupal-version: '10.0.x-dev'
php-versions: '8.1'
mysql: "8.0"
test-suite: "kernel"
allowed_failure: true
- drupal-version: '10.0.x-dev'
php-versions: '8.1'
mysql: "8.0"
test-suite: "functional"
allowed_failure: true
- drupal-version: '10.0.x-dev'
php-versions: '8.1'
mysql: "8.0"
test-suite: "functional-javascript"
allowed_failure: true


name: PHP ${{ matrix.php-versions }} | drupal ${{ matrix.drupal-version }} | mysql ${{ matrix.mysql }} | test-suite ${{ matrix.test-suite }}

Expand Down Expand Up @@ -175,7 +98,6 @@ jobs:
cd $DRUPAL_DIR
chmod -R u+w web/sites/default
mkdir -p web/sites/simpletest/browser_output
continue-on-error: ${{ matrix.allowed_failure }}

- name: Setup composer paths
run: |
Expand All @@ -190,18 +112,15 @@ jobs:
cd $DRUPAL_DIR/web
drush --uri=127.0.0.1:8282 en -y islandora_audio islandora_breadcrumbs islandora_iiif islandora_image islandora_video islandora_text_extraction_defaults
drush --uri=127.0.0.1:8282 fim -y islandora_core_feature,islandora_text_extraction_defaults
continue-on-error: ${{ matrix.allowed_failure }}

- name: Copy PHPunit file
run: cp $PHPUNIT_FILE $DRUPAL_DIR/web/core/phpunit.xml

- name: Test scripts
run: $SCRIPT_DIR/travis_scripts.sh
continue-on-error: ${{ matrix.allowed_failure }}

- name: PHPUNIT tests
run: |
cd $DRUPAL_DIR/web/core
$DRUPAL_DIR/vendor/bin/phpunit --verbose --testsuite "${{ matrix.test-suite }}"
continue-on-error: ${{ matrix.allowed_failure }}

2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# ![Islandora](https://cloud.githubusercontent.com/assets/2371345/25624809/f95b0972-2f30-11e7-8992-a8f135402cdc.png) Islandora

[![Minimum PHP Version](https://img.shields.io/badge/php-%3E%3D%207.2-8892BF.svg?style=flat-square)](https://php.net/)
[![Minimum PHP Version](https://img.shields.io/badge/php-%3E%3D%207.4-8892BF.svg?style=flat-square)](https://php.net/)
[![Build Status](https://github.com/islandora/islandora/actions/workflows/build-2.x.yml/badge.svg)](https://github.com/Islandora/islandora/actions)
[![Contribution Guidelines](http://img.shields.io/badge/CONTRIBUTING-Guidelines-blue.svg)](./CONTRIBUTING.md)
[![LICENSE](https://img.shields.io/badge/license-GPLv2-blue.svg?style=flat-square)](./LICENSE)
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"drupal/context": "^4.0@beta",
"drupal/search_api": "~1.8",
"islandora/jsonld": "^2",
"stomp-php/stomp-php": "4.*",
"stomp-php/stomp-php": "4.* || ^5",
"drupal/jwt": "^1.0.0-beta5",
"drupal/filehash": "^1.1 || ^2",
"drupal/prepopulate" : "^2.2",
Expand Down
8 changes: 5 additions & 3 deletions tests/src/Functional/IslandoraFunctionalTestBase.php
Original file line number Diff line number Diff line change
Expand Up @@ -278,11 +278,13 @@ protected function createPreservationMasterTag() {
* Creates a test context.
*/
protected function createContext($label, $name) {
$this->drupalPostForm('admin/structure/context/add', [
$this->drupalGet('admin/structure/context/add');
$values = [
'label' => $label,
'name' => $name,
],
$this->t('Save'));
];
$this->submitForm($values, 'Save');

$this->assertSession()->statusCodeEquals(200);
}

Expand Down