Fill in blanks for IntegerWeightSelector (Islandora#2065)

[antbrown]

GitHub Issue: Islandora/documentation#2065

What does this Pull Request do?

Fills in the blanks on the IntegerWeightSelector views form when the number of $options is less than the total number of rows in the view.

What's new?

• Add condition to if statement on https://github.com/Islandora/islandora/blob/2.x/src/Plugin/views/field/IntegerWeightSelector.php#L54

How should this be tested?

• Reproduce issue by creating a paged content repository item, add two child objects, set both of their weights to 1 and save.

Documentation Status

• I don't think this requires any changes to documentation.

Additional Notes:

none.

Interested parties

@Islandora/8-x-committers

[jordandukart]

Nice catch, can confirm this change does allow for more options than just a singular 1 to be present.

[jordandukart]

Going to let this percolate for a day or so and if no-one objects I'll merge and mint a patch release.

[antbrown]

Thanks @jordandukart - I missed some extra whitespace at the end of a comment. If possible, I suggest squashing the two commits together if it gets approved. Cheers, Ant.

[antbrown]

The tests that failed look like they couldn’t resolve dependencies- looks unrelated to the change I’ve made.

[jordandukart]

Yep tests are being fixed in https://github.com/Islandora/islandora/pull/862/files, once that gets in we'll move this along. Honestly if I had admin I'd just merge now as your changes aren't what's breaking the tests.