Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using context_definitions annotation instead of the deprecated contex… #764

Merged
merged 6 commits into from
Mar 25, 2020
Merged

Using context_definitions annotation instead of the deprecated contex… #764

merged 6 commits into from
Mar 25, 2020

Conversation

dannylamb
Copy link

…t annotation

Github Issue: Resolves Islandora/documentation#1274

What does this Pull Request do?

Replaces the deprecated context annotation with context_definitions in our plugins. See https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Condition%21Annotation%21Condition.php/property/Condition%3A%3Acontext/8.7.x

How should this be tested?

You shouldn't see a noticeable change. So if you pull in this PR and nothing breaks, it's good!

Interested parties

@Islandora/8-x-committers

@seth-shaw-unlv
Copy link

@dannylamb, tests failed:

Drupal\Tests\islandora\Functional\NodeHasTermTest::testNodeHasTerm
    Drupal\Component\Plugin\Exception\ContextException: The node context is not
    a valid context.

@dannylamb
Copy link
Author

Gah, tests work fine locally. It's a Travis issue 😭

@whikloj
Copy link
Member

whikloj commented Mar 18, 2020

Lots of tests failing here. I'll give it a try.

@dannylamb
Copy link
Author

FWIW on latest Ubuntu:

Test summary
------------

Drupal\Tests\islandora\FunctionalJavascript\IntegerWeightTes   1 passes                                      
Drupal\Tests\islandora\Functional\AddMediaToNodeTest           1 passes                                      
Drupal\Tests\islandora\Functional\ContentEntityTypeTest        1 passes                                      
Drupal\Tests\islandora\Functional\DeleteMediaTest              1 passes                                      
Drupal\Tests\islandora\Functional\DerivativeReactionTest       1 passes                                      
Drupal\Tests\islandora\Functional\EmitNodeEventTest            1 passes                                      
Drupal\Tests\islandora\Functional\EntityBundleTest             1 passes                                      
Drupal\Tests\islandora\Functional\FormDisplayAlterReactionTe   1 passes                                      
Drupal\Tests\islandora\Functional\IndexingTest                 1 passes                                      
Drupal\Tests\islandora\Functional\IslandoraImageFormatterTes   1 passes                                      
Drupal\Tests\islandora\Functional\IslandoraSettingsFormTest    2 passes                                      
Drupal\Tests\islandora\Functional\JsonldSelfReferenceReactio   2 passes                                      
Drupal\Tests\islandora\Functional\JsonldTypeAlterReactionTes   2 passes                                      
Drupal\Tests\islandora\Functional\LinkHeaderTest               2 passes                                      
Drupal\Tests\islandora\Functional\MediaSourceUpdateTest        1 passes                                      
Drupal\Tests\islandora\Functional\NodeHasTermTest              1 passes                                      
Drupal\Tests\islandora\Functional\ViewModeAlterReactionTest    1 passes                                      
Drupal\Tests\islandora\Kernel\EventGeneratorTest               3 passes                                      
Drupal\Tests\islandora\Kernel\FedoraAdapterTest               33 passes                                      
Drupal\Tests\islandora\Kernel\FedoraPluginTest                 2 passes                                      
Drupal\Tests\islandora\Kernel\GeminiClientFactoryTest          3 passes                                      
Drupal\Tests\islandora\Kernel\GeminiLookupTest                 7 passes                                      
Drupal\Tests\islandora\Kernel\JwtEventSubscriberTest           5 passes                                      

Test run duration: 54 min 40 sec

It's just a Travis thang.

This was referenced Mar 20, 2020
Merged
Merged
Merged
Merged
seth-shaw-unlv
seth-shaw-unlv approved these changes Mar 25, 2020
View reviewed changes
Copy link

@seth-shaw-unlv seth-shaw-unlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@seth-shaw-unlv seth-shaw-unlv merged commit e9bea0d into Islandora:8.x-1.x Mar 25, 2020
@dannylamb
Copy link
Author

🙇‍♂️

@JojoVes JojoVes mentioned this pull request Jan 26, 2023
Merged
seth-shaw-asu pushed a commit that referenced this pull request Feb 1, 2023
@JojoVes
Replace deprecated 'context' condition annotation with 'context_defin…
c36f7d9 
…itions' (#925)

There was a cleanup done for this deprecation in #764
before the 'NodeReferencedByNode' condition was made, then the deprecated annotation must have
just been missed in reviewing #808.
rosiel pushed a commit to rosiel/islandora that referenced this pull request Feb 22, 2023
@JojoVes @rosiel
Replace deprecated 'context' condition annotation with 'context_defin…
62c3537 
…itions' (Islandora#925)

There was a cleanup done for this deprecation in Islandora#764
before the 'NodeReferencedByNode' condition was made, then the deprecated annotation must have
just been missed in reviewing Islandora#808.
rosiel pushed a commit that referenced this pull request Jul 6, 2023
@JojoVes @rosiel
Replace deprecated 'context' condition annotation with 'context_defin…
2376f77 
…itions' (#925)

There was a cleanup done for this deprecation in #764
before the 'NodeReferencedByNode' condition was made, then the deprecated annotation must have
just been missed in reviewing #808.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seth-shaw-unlv seth-shaw-unlv seth-shaw-unlv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dannylamb @seth-shaw-unlv @whikloj