Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copyright line to mkdocs.yml (#1725) #1726

Merged
merged 2 commits into from
Jan 13, 2021
Merged

Add copyright line to mkdocs.yml (#1725) #1726

merged 2 commits into from
Jan 13, 2021

Conversation

highermath
Copy link
Contributor

@highermath highermath commented Dec 4, 2020

Purpose / why

Add lines to footer to facilitate linking to resources.

What changes were made?

Added copyright line to mkdocs.yml

Note

The dummy lines must be changed to something useful before pushing to production.

Verification

These two dummy lines should appear in the footer above the Made with Material for MkDocs line
Some info about contributing can go here!
Change this in the copyright line in mkdocs.yml

Interested Parties

*@Islandora/8-x-committers


Checklist

Pull-request reviewer should ensure the following

  • Does this PR link to related issues?
  • Does the proposed documentation align with the Islandora Documentation Style Guide?
  • Are the changes accurate, useful, free of typos, etc?
  • Does this PR update the last updated on date on the documentation page?

Person merging should ensure the following

  • Does mkdocs still build successfully? (This is indicated by TravisCI passing. To test locally, and see warnings, see How To Build Documentation.)
  • If pages are renamed or removed, have all internal links to those pages been fixed?
  • If pages are added, have they been linked to or placed in the menu?
  • Did the PR receive at least one approval from a committer, and all issues raised have been addressed?

@rosiel
Copy link
Member

rosiel commented Dec 4, 2020

Addresses #1713

@rosiel
Copy link
Member

rosiel commented Dec 4, 2020

How about

<b>This documentation is user-sourced!</b> Suggestions and comments are welcome in our <u><a href="https://github.com/Islandora/documentation/issues" target="_blank">issue queue</a></u>. 

as a start? (ideally, there'd be a landing page for getting involved with documentation, but right now it's too spread out to work well)

@manez
Copy link
Member

manez commented Dec 4, 2020

I've put a PR in moments ago to create a page walking through how to create an issue: #1727

@rosiel
Copy link
Member

rosiel commented Dec 8, 2020

Put a PR against your PR: #1734

@manez
Copy link
Member

manez commented Dec 16, 2020

@highermath any chance this can go through soonish?

@manez manez merged commit 35f5283 into main Jan 13, 2021
@rosiel rosiel deleted the highermath branch July 14, 2021 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants