Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra info from readme. #1673

Merged
merged 4 commits into from
Nov 13, 2020
Merged

Remove extra info from readme. #1673

merged 4 commits into from
Nov 13, 2020

Conversation

rosiel
Copy link
Member

@rosiel rosiel commented Oct 30, 2020

Purpose / why

The readme was like a mini documentation about the Islandora project. I streamlined it and tried to redirect viewers to the github pages.

What changes were made?

Removed the submodules bit, and the section where they were described as part of "this repository's structure".

I took out A LOT that was islandora-related:

  • installation
  • sponsors
  • links to the tech calls
  • changed 'maintainers' to a link to the DIG

Verification

Please comment if you think that some of this needs to be back in, in one form or another!

Interested Parties

@manez @dannylamb @eldonquijote (Jeff Rubin?)


Checklist

Pull-request reviewer should ensure the following

Person merging should ensure the following

  • Does mkdocs still build successfully? (This is indicated by TravisCI passing. To test locally, and see warnings, see How To Build Documentation.)
  • If pages are renamed or removed, have all internal links to those pages been fixed?
  • If pages are added, have they been linked to or placed in the menu?
  • Did the PR receive at least one approval from a committer, and all issues raised have been addressed?

@manez
Copy link
Member

manez commented Oct 30, 2020

Can we add some mention of the wiki? This is one of the two repos in our org that has an active wiki we use for stuff. "Additional resources and information about community meetings is available in wiki" or something to that effect?

README.md Outdated

This repository contains the user, developer, and administrator documentation for the [Islandora project](https://islandora.ca/), for versions 8 and above. This documentation is available to read at https://islandora.github.io/documentation/, where it is automatically deployed on commit from the source code at https://github.com/Islandora/documentation. Documentation for Islandora 7.x and previous versions is available at https://wiki.lyrasis.org/display/ISLANDORA/.
## About the Documentation
Copy link
Member

@manez manez Nov 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't seem to manage a pull request against your fork, but I do have some wording here to roll in @eldonquijote 's suggestion:

## About the Documentation

This repository has three primary uses:

- it contains source code for the user, developer, and administrator documentation for versions 8.x and above of the [Islandora project](https://islandora.ca/). It is written in mkdocs and can be viewed on [our Github Pages site](https://islandora.github.io/documentation/).
- its [Wiki](https://github.com/Islandora/documentation/wiki) contains the minutes for Islandora 8 Tech calls and User calls.
- it hosts the central [issue queue](https://github.com/Islandora/documentation/issues) for the entire Islandora 8 project.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a couple changes for brevity - does it still work?

@manez
Copy link
Member

manez commented Nov 9, 2020

Tagging @jrubin6 since he is name-dropped in the PR too :)

Copy link
Contributor

@eldonquijote eldonquijote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@manez manez merged commit c114748 into Islandora:main Nov 13, 2020
@rosiel rosiel deleted the update-readme branch November 13, 2020 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants