-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Versioning #75
Versioning #75
Conversation
…ass in the resource URI
…so we don't have to repeat it in createVersion and getVersion
note: i will work on tests for this also. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elizoller this is good work, I have some suggestions but as I haven't tested this if you have reasons for the path you took please let me know.
I think I got those suggestions above resolved. And added some tests. How does it look? |
@elizoller can you make a change to the
Travis isn't running because now we are using dev as our "development" branch, is this correct @dannylamb or should we be merging to master? |
Going to look more at the test for createVersion based on https://codecov.io/gh/Islandora-CLAW/chullo/src/48baf212cca7540247eb152725d5525c6906b543/src/FedoraApi.php 😞 |
Codecov Report
@@ Coverage Diff @@
## dev #75 +/- ##
==========================================
+ Coverage 97.01% 100% +2.98%
- Complexity 12 20 +8
==========================================
Files 1 1
Lines 67 98 +31
==========================================
+ Hits 65 98 +33
+ Misses 2 0 -2
Continue to review full report at Codecov.
|
@whikloj merge to dev, please. that's why I set it up as the default branch, just to nudge us in that direction. |
nice wall of green there @elizoller 🎉 |
Nicely done @elizoller |
GitHub Issue: (Islandora/documentation#740)
What does this Pull Request do?
Bring chullo up to meet the versioning API spec
What's new?
How should this be tested?
In theory, write a PHP script which calls these methods. In reality, might be easier to use Milliner in an existing Islandora site, something like - Islandora/Crayfish@dev...asulibraries:versioning which will hopefully be the start of a corresponding PR.
Additional Notes:
Fedora Versioning API Spec - https://wiki.duraspace.org/display/FEDORA5x/RESTful+HTTP+API+-+Versioning#RESTfulHTTPAPI-Versioning-BluePOSTCreateanewversionedresource(anewLDPRm)
Interested parties
@Islandora-CLAW/committers