Implement copyResource -- Address #10. #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 8, 2015
Closed
| * @return string | ||
| */ | ||
| public function copyResource($uri, | ||
| $destination); |
There was a problem hiding this comment.
I'd add transactionality here too. Might want to do a lot of copying inside a transaction. All you'll have to do is call prepareUri in your implementation.
There was a problem hiding this comment.
Cool. I psyched myself out of including it 😄
Closed
| // Ensure uri takes transaction into account. | ||
| $uri = $this->prepareUri($uri, $transaction); | ||
| // Create destinsation URI | ||
| $destination_uri = "Destination: " . $destination; |
There was a problem hiding this comment.
You'll need to prepare this URI, as well.
Conflicts: src/Chullo.php src/IFedoraClient.php
|
Looks good. Merging. |
daniel-dgi
added a commit
that referenced
this pull request
Dec 7, 2015
Implement copyResource -- Address #10.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #10
Still need to get TravisCI hooked up proper.
You can see the build here. It appears to be passing. But, same as with #19, I'm not confident I'm doing things right here.
tags @Islandora-CLAW/7-x-2-x-committers