Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed for https://github.com/digitalutsc/advanced_search/issues/4 #44

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

kylehuynh205
Copy link
Contributor

@kylehuynh205 kylehuynh205 commented Mar 14, 2024

What does this Pull Request do?

image

  • The search is ignoring the field search condition and searches as Keyword only.

What's new?

There is no new functionality to be added. Only add a if check to handle boolean search which is mixed with Keyword and field.

How should this be tested?

  • Apply boolean search with mixed Keyword and Field Search:

  • Before this PR show 41 results,

https://sandbox.islandora.ca/search?a%5B0%5D%5Bf%5D=all&a%5B0%5D%5Bi%5D=IS&a%5B0%5D%5Bv%5D=%22wild%20flowers%22&a%5B1%5D%5Bc%5D=AND&a%5B1%5D%5Bf%5D=title_aggregated_fulltext&a%5B1%5D%5Bi%5D=IS&a%5B1%5D%5Bv%5D=Excerpt

  • After PR it show 1 results:

image

Documentation Status

No needed Documentation.

Additional Notes:

N/A

Interested parties

@Islandora/committers

@rosiel rosiel self-assigned this Apr 3, 2024
Copy link
Member

@rosiel rosiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works. I replicated the issue on my own data and this fixes the issue.

@rosiel rosiel merged commit 2bc8c28 into Islandora:2.x Apr 9, 2024
@kylehuynh205 kylehuynh205 deleted the boolean-search-issue branch July 5, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants