Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deCLAW Crayfish for #1267 and #1314 #81

Merged
merged 42 commits into from
Oct 25, 2019
Merged

deCLAW Crayfish for #1267 and #1314 #81

merged 42 commits into from
Oct 25, 2019

Conversation

manez
Copy link
Member

@manez manez commented Oct 23, 2019

GitHub Issue: Islandora/documentation#1267 and Islandora/documentation#1314

What does this Pull Request do?

Cleans out the last few traces of CLAW in urls and references. This should get it all!

What's new?

New mascot for Recast, a few new sections in submodule readmes. A lot less CLAW.

How should this be tested?

Preview the files and verify that the links still work.

Interested parties

@jonathangreen new maintainer 😄

@codecov
Copy link

codecov bot commented Oct 23, 2019

Codecov Report

Merging #81 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                dev      #81   +/-   ##
=========================================
  Coverage     94.64%   94.64%           
  Complexity      160      160           
=========================================
  Files             9        9           
  Lines           654      654           
=========================================
  Hits            619      619           
  Misses           35       35

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d41371b...fda1810. Read the comment docs.

@@ -2,7 +2,7 @@
@prefix owl:<http://www.w3.org/2002/07/owl#> .
@prefix ebucore:<http://www.ebu.ch/metadata/ontologies/ebucore/ebucore#> .
@prefix ldp:<http://www.w3.org/ns/ldp#> .
@prefix islandora:<http://islandora.ca/CLAW#> .
@prefix islandora:<http://islandora.ca/islandora8> .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a # after islandora8.

@@ -2,7 +2,7 @@
@prefix owl:<http://www.w3.org/2002/07/owl#> .
@prefix ebucore:<http://www.ebu.ch/metadata/ontologies/ebucore/ebucore#> .
@prefix ldp:<http://www.w3.org/ns/ldp#> .
@prefix islandora:<http://islandora.ca/CLAW#> .
@prefix islandora:<http://islandora.ca/islandora8> .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a # after islandora8.

@@ -2,7 +2,7 @@
@prefix owl:<http://www.w3.org/2002/07/owl#> .
@prefix ebucore:<http://www.ebu.ch/metadata/ontologies/ebucore/ebucore#> .
@prefix ldp:<http://www.w3.org/ns/ldp#> .
@prefix islandora:<http://islandora.ca/CLAW#> .
@prefix islandora:<http://islandora.ca/islandora8> .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a # after islandora8.

@@ -2,7 +2,7 @@
@prefix owl:<http://www.w3.org/2002/07/owl#> .
@prefix ebucore:<http://www.ebu.ch/metadata/ontologies/ebucore/ebucore#> .
@prefix ldp:<http://www.w3.org/ns/ldp#> .
@prefix islandora:<http://islandora.ca/CLAW#> .
@prefix islandora:<http://islandora.ca/islandora8> .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a # after islandora8.

README.md Outdated
@@ -1,10 +1,12 @@
# ![Crayfish](https://cloud.githubusercontent.com/assets/2371345/15409657/2dfb463a-1dec-11e6-9089-06df94ef3f37.png) Crayfish

[![Minimum PHP Version](https://img.shields.io/badge/php-%3E%3D%205.6-8892BF.svg?style=flat-square)](https://php.net/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be (I think)

https://img.shields.io/badge/php-%3E%3D%207.2-8892BF.svg?style=flat-square

@@ -1,6 +1,6 @@
@prefix apix: <http://fedora.info/definitions/v4/api-extension#> .
@prefix ldp: <http://www.w3.org/ns/ldp#> .
@prefix islandora: <http://islandora.ca/CLAW#> .
@prefix islandora: <http://islandora.ca/islandora8> .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a # after islandora8.

Copy link
Member

@whikloj whikloj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small things, might be more but I did not do a comprehensive reading.

@manez
Copy link
Member Author

manez commented Oct 25, 2019

There were similar issues across other .ttl files. I think I got them all.

@@ -1,3 +1,4 @@
# ![Recast Mascot](https://user-images.githubusercontent.com/2371345/67399869-3ded6600-f583-11e9-8fec-8e82d57a6d4d.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@whikloj whikloj merged commit 30ec57d into Islandora:dev Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants