Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimum-stability & prefer-stable to get chullo:dev #75

Merged
merged 1 commit into from
Aug 7, 2019

Conversation

whikloj
Copy link
Member

@whikloj whikloj commented Aug 7, 2019

GitHub Issue: N/A

Still trying to get correct chullo into Crayfish related to #74 test failures

What does this Pull Request do?

  1. Update all lockfiles to PHP 7.2
  2. Update chullo/crayfish-commons to dev branches
  3. Update travis testing to remove 7.1 and add 7.3 as an allowed failure.

What's new?

How should this be tested?

Travis really.

Interested parties

@Islandora-CLAW/committers

Remove 7.1

Add minimum-stability & prefer-stable to get chullo:dev
@codecov
Copy link

codecov bot commented Aug 7, 2019

Codecov Report

Merging #75 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                dev      #75   +/-   ##
=========================================
  Coverage     94.59%   94.59%           
  Complexity      159      159           
=========================================
  Files             9        9           
  Lines           647      647           
=========================================
  Hits            612      612           
  Misses           35       35

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fcf192...a39faad. Read the comment docs.

@whikloj
Copy link
Member Author

whikloj commented Aug 7, 2019

If this looks good, I'll make one to Crayfish-Commons and Chullo to update for 7.2 and test against 7.3

Copy link
Contributor

@dannylamb dannylamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do this :shipit:

@dannylamb dannylamb merged commit ff58f34 into Islandora:dev Aug 7, 2019
@whikloj whikloj deleted the update-lockfile branch September 12, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants