patched Houdini convert method to add when making call #163
Conversation
…ng for it in code.
Codecov ReportBase: 76.60% // Head: 74.45% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## 2.x #163 +/- ##
============================================
- Coverage 76.60% 74.45% -2.15%
+ Complexity 161 149 -12
============================================
Files 6 5 -1
Lines 654 599 -55
============================================
- Hits 501 446 -55
Misses 153 153
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Oh codecov, guiltin' me as always. Hang on. |
|
I don't understand, I added test coverage codecov!!!! |
|
Anyhow, I did totally add tests around the branch i introduced for checking if it's a pdf. @Islandora/committers this is good to check out. |
|
FYI you can test with Islandora-Devops/isle-buildkit#216 |
|
🙇 thanks @seth-shaw-asu ! |
|
My pleasure. We already have this in production which has resolved some of our problematic thumbnails. |
* patched Houdini convert method to add when making call (#163) * Fix one test and remove some duplicate code Co-authored-by: dannylamb <[email protected]>
GitHub Issue: Islandora/documentation#2165
What does this Pull Request do?
Tells houdini to only use the first page to generate a derivative.
What's new?
A slightly modified imagemagick command if you're pulling images from a PDF
How should this be tested?
Upload a big PDF (50+ MB) and wait a while. Check the size of the thumbnail/service file that gets generated. Apply this PR to Crayfish and do it again. It should be faster and the image should be smaller.