Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignoring KarafIT until Pax Exam 4.14.0 is released #69

Merged
merged 1 commit into from
Feb 20, 2020
Merged

Conversation

whikloj
Copy link
Member

@whikloj whikloj commented Feb 20, 2020

GitHub Issue: Islandora/documentation#1443

https://groups.google.com/forum/#!topic/ops4j/pJ98QaBVPfE/discussion
https://ops4j1.jira.com/browse/PAXEXAM-934

What does this Pull Request do?

Ignores the PaxExam test class.

We need to wait for the 4.14.0 release to re-enable and correct the default maven central address.
Once it is released we can re-enable the test.

How should this be tested?

Empty your maven repository (~/.m2/repository on Mac/Linux)
Build this PR and it passes

Interested parties

@Islandora/8-x-committers - especially @elizoller

@codecov
Copy link

codecov bot commented Feb 20, 2020

Codecov Report

Merging #69 into dev will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                dev      #69   +/-   ##
=========================================
  Coverage     89.76%   89.76%           
  Complexity       73       73           
=========================================
  Files            10       10           
  Lines           293      293           
  Branches          1        1           
=========================================
  Hits            263      263           
  Misses           29       29           
  Partials          1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1dab02...c38cbd5. Read the comment docs.

@elizoller
Copy link
Member

I pulled this down and was able to build Alpaca successfully.

@elizoller
Copy link
Member

@dannylamb did you want to weigh in on this or should i do an official review?

@dannylamb
Copy link
Contributor

By all means, please merge @elizoller. You don't have to wait for me.

@whikloj
Copy link
Member Author

whikloj commented Feb 20, 2020

I'm interested in what an "official review" of an @Ignore annotation looks like 😀

Copy link
Member

@elizoller elizoller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works in order to allow Alpaca to build although in my opinion I think it'd be important to open another ticket linked to this pull request so that it isn't lost that updating PaxExam will need to be addressed in the future.

@elizoller elizoller merged commit b0c2bd1 into dev Feb 20, 2020
@rosiel rosiel deleted the issue-1443 branch August 27, 2021 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants