Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update search_api_solr to 3.8 #157

Merged
merged 7 commits into from
Mar 12, 2020

Conversation

elizoller
Copy link
Member

What does this Pull Request do?

Updates search_api_solr to version 3.8

What's new?

  • Updates search_api_solr to version 3.8
  • Per the install.md - adds a patch for Drupal Core
  • Per the install.md - uses drush command to generate the default solr config files
  • Reorders the playbook.yml so that solr.yml runs after webserver.yml because the solr config setup requires the output of the drush command

How should this be tested?

Additional Notes:

I was concerned about conflating the solr host and the webserver host so that is why I implemented the "Unarchive solr config" as a request to localhost instead of directly from a file path like /var/www/...

Interested parties

@Islandora-Devops/committers

@seth-shaw-unlv
Copy link
Contributor

Results in a warning: "Solarium 5.0.2 is too old and has known issues. "

To alleviate this we can update the composer task to be:

- name: Add a patch for symfony-event-dispatcher per the INSTALL.md docs on search_api_solr:3.8
  composer:
    command: require
    arguments: symfony/event-dispatcher:'4.3.4 as 3.4.99' solarium/solarium:^5.1.4 drupal/search_api_solr
    working_dir: "{{ drupal_composer_install_dir }}"

I'm building a new instance with this revised task right now.

@elizoller
Copy link
Member Author

awesome, thanks @seth-shaw-unlv

@seth-shaw-unlv
Copy link
Contributor

seth-shaw-unlv commented Mar 12, 2020

So, this works!
Screen Shot 2020-03-12 at 9 03 55 AM

HOWEVER, this screen shot is taken before we import the islandora_search configs. Doing the feature import breaks the Solr Server config. With the updated search_api_solr module they appear to assume solr will be accessible @ '/solr/' so the linked config line turns http://127.0.0.1:8983/solr/#/ISLANDORA into http://127.0.0.1:8983/solr/solr/#/ISLANDORA. I don't know why they did that, but there it is.

So, @elizoller , if you can add that solarium bit to the composer command in this PR we can merge this one. I'll create a new PR on islandora_defaults to purge the path config.

Copy link
Contributor

@seth-shaw-unlv seth-shaw-unlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formalizing the requested change....

@seth-shaw-unlv
Copy link
Contributor

Spinning up another instance to double check before merge.

@elizoller
Copy link
Member Author

This build completed successfully for me and no more solarium warning

@seth-shaw-unlv
Copy link
Contributor

seth-shaw-unlv commented Mar 12, 2020

I forgot to pull in the Grok playbook fix for CentOS so my build died. 🤦‍♂️ It is building again and should be done in a little while.

@seth-shaw-unlv seth-shaw-unlv merged commit 7533059 into Islandora-Devops:dev Mar 12, 2020
@elizoller elizoller deleted the update_solr branch July 10, 2020 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants