-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fits #129
Merged
Merged
Fits #129
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
cb28282
Pulling in FITS work
dannylamb 0ed7454
Pushing before making PR
dannylamb f5679b7
Merge branch 'dev' into fits
dannylamb e1f8b06
Un-derping the feature import
dannylamb 1a09995
Merge branch 'dev' of https://github.com/Islandora-Devops/claw-playbo…
dannylamb f84baa0
Merge branch 'dev' into fits
dannylamb ed205fd
Pointing back to Origin
dannylamb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,3 +11,4 @@ | |
- Islandora-Devops.grok | ||
- Islandora-Devops.cantaloupe | ||
- Islandora-Devops.activemq | ||
- Islandora-Devops.fits |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you not enabling islandora_defaults and importing it anymore? Did it move somewhere else? When I ran a fresh build, I lost a lot of the settings like having media use on the media types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is being enabled (as a module) @dannylamb added it to the
drupal_enabled_modules
ansible variable, but we probably still need this line to import the feature because it is not imported by default.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, I manually ran drush en and it was already enabled, then I ran the drush fim and it fixed the missing things 👍 (and then a FITS media object was made! )