-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated README.md and created new index.md #11
Conversation
3. [git](https://git-scm.com/) | ||
4. [ansible](https://www.ansible.com/community) 2.3+ | ||
1. [VirtualBox](https://www.virtualbox.org/wiki/Downloads) 5.1+ | ||
2. [Vagrant](https://www.vagrantup.com/downloads.html) 1.95+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming that 1.95+ here is supposed to be 1.9.5+.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MarcusBarnes Good catch! that should be 1.9.5+ for sure. Thanks!
* `guest: 8000, host: 8000` # **Apache** | ||
* `guest: 8080, host: 1234` # **Tomcat** | ||
* `guest: 8181, host: 8181` # **Karaf** | ||
* `guest: 8282, host: 8282` # **Islandora Microservices** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line can be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or more accurately, should be replaced with
guest: 8081, host: 8081
# Api-X
|
||
* List of commands here | ||
|
||
## Ansible Playbook structure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this section goes a little too detailed. I think the directory structure of the repo changes fairly quickly, and including it here assures that it will be outdated soon.
@g7morris other then the couple comments here, I think the style of this is good and its always great to have some more docs. |
This should probably get pushed through before the sprint. Just a suggestion. This does look like a good start and if @g7morris doesn't have the time to make the suggested modifications I think it would be useful to push it through as it sits. This would be a good starting point. |
Out of date, sadly. Closing |
Hello Team,
I've updated the README.md and have created a stub index.md for more details which I hope to fill prior to Friday.
@jonathangreen @dannylamb Style okay? Too much, too little.
Thanks,
Gavin