Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post merge fixes #366

Merged
merged 2 commits into from
Aug 4, 2019
Merged

Post merge fixes #366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66f440a
Fix not converting NodeList to Array
MxtOUT Aug 4, 2019
d47e964
Check result object for existence of keys
MxtOUT Aug 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions js/background/background.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,8 +421,8 @@ class SteamCommunity extends Api {
result = await SteamCommunity.getEndpoint(`/inventory/${login.steamId}/753/${contextId}`, thisParams);
if (result && result.success) {
if (!data) data = { "assets": [], "descriptions": [] };
data.assets = data.assets.concat(result.assets);
data.descriptions = data.descriptions.concat(result.descriptions);
if (result.assets) data.assets = data.assets.concat(result.assets);
if (result.descriptions) data.descriptions = data.descriptions.concat();
}
last_assetid = result.last_assetid;
} while (result.more_items);
Expand Down
2 changes: 1 addition & 1 deletion js/content/store.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ class Customizer {
let elements;

if (typeof targets === "string") {
elements = document.querySelectorAll(targets);
elements = Array.from(document.querySelectorAll(targets));
} else if (targets instanceof NodeList) {
elements = Array.from(targets);
} else {
Expand Down