Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hotkeys on Windows by adding a custom hook #262

Merged
merged 4 commits into from
Dec 21, 2023

Conversation

codemile
Copy link
Collaborator

Adds a hook that applies an onKeyUp listener to window and triggers menu actions.

Only applies the hook when the userAgent is Win64.

Resolves #261

@codemile codemile changed the title fixes hotkeys on Windows by adding a custom hook fix: hotkeys on Windows by adding a custom hook Dec 14, 2023
Copy link
Collaborator

@abrenneke abrenneke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple small things, otherwise looks good!

packages/app/src/hooks/useWindowsHotfix.tsx Outdated Show resolved Hide resolved
packages/app/src/hooks/useWindowsHotfix.tsx Outdated Show resolved Hide resolved
packages/app/src/hooks/useWindowsHotfix.tsx Outdated Show resolved Hide resolved
packages/app/src/hooks/useWindowsHotfix.tsx Outdated Show resolved Hide resolved
@codemile
Copy link
Collaborator Author

thanks, I'll push changes later today.

@codemile codemile force-pushed the fix/windows-hotkeys branch from fdff37b to 22ce6b2 Compare December 20, 2023 11:58
@codemile
Copy link
Collaborator Author

Done, thanks for the feedback.

Copy link
Collaborator

@abrenneke abrenneke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome thank you!

@abrenneke abrenneke merged commit ccfcb6b into Ironclad:main Dec 21, 2023
1 check passed
@codemile codemile deleted the fix/windows-hotkeys branch January 2, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Global hot keys on Windows do not work
2 participants