First pass at adding arm64 to the build. #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both node-pre-gyp and rust need different platform and architecture arguments since we have to cross compile. There aren't currently M1 action runners available to do this natively. Uses rust-toolchain to set the default to the current matrix option, need to make sure that works and that the linker used doesn't get messed up for musl builds for ex.
skeet70
requested review from
coltfred and
cjyar
and removed request for
a team
|
No changes to code coverage between the base branch and the head branch |
BobWall23
approved these changes
Jan 14, 2022
cjyar
approved these changes
Jan 14, 2022
|
No changes to code coverage between the base branch and the head branch |
|
No changes to code coverage between the base branch and the head branch |
|
No changes to code coverage between the base branch and the head branch |
|
The only failure here is due to the issue mentioned in #74, I'm going merge and see if the pre-release works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both node-pre-gyp and rust need different platform and architecture
arguments since we have to cross compile. There aren't currently M1
action runners available to do this natively.
Uses rust-toolchain to set the default to the current matrix option,
need to make sure that works and that the linker used doesn't get messed
up for musl builds for ex.
This is in support of IronCoreLabs/ironnode#70