Use Item Model instead of raw Item ids for uniform lookup. #2558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patbox
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like title. This change shouldn't change anything if modded (and vanilla items) didn't override item_model component (aka it matches registry id, which is currently the default).
If player gets an item with custom item_model, the uniform will depend purely on that. It should solve issues with some unintended effects caused by servers using base items that get some shader related effects.
This change doesn't apply to Block Items as to not change the logic, through in my opinion it should, as some blocks use different block and item models, which might make them look wrong.