Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/stained glass template #66

Open
wants to merge 48 commits into
base: main
Choose a base branch
from

Conversation

davidianstyle
Copy link
Contributor

Here's my (revised) PR for a Stained Glass template frame plugin:

  • Selects frame based on color identity as opposed to color
  • Supports 0-color, 1-color, 2-color, 3-color identity cards
  • Land and Artifact have their own unique colored frames
  • 4-color and 5-color identity cards use default Gold frame

Not currently supported:

  • 4-color identity, 5-color identity cards (showing their specified colors)
  • Planeswalker frame

Future enhancements to be added later:

  • Toggle option to choose card frame based on color identity instead of color (default = false)
  • Create alternate frame without holo stamp
  • Add 4-color identity frame support
  • Add 5-color identity frame support
  • Add planeswalker frame support

Example renders:

Arcane Signet (Gaboleps)  Stained Glass

Dakkon Blackblade (Richard Kane Ferguson)  Stained Glass

Xander's Lounge (Dominik Mayer)  Stained Glass

Feedback appreciated!

@Investigamer
Copy link
Owner

I resolved the conflicts from merging the settings-panels branch in, will take a look at the full code changes soon 👍

Investigamer and others added 24 commits January 30, 2023 15:17
Also deprecated config section as this is now outlined in the GUI.
Added default "Normal" Class template, available on gdrive and via the updater.
…utilities

New helpers include: get_color(), apply_rgb(), apply_cmyk(), copy_layer_mask(), duplicate_group(), import_art(), and import_svg()
…ion Symbol now rendered using these effects

New helpers have been introduced that can apply layer affects using given effects dictionary. These include apply_fx(), apply_fx_stroke(), apply_fx_gradient(), apply_fx_drop_shadow(), with more to be added in the future. The solidcolor() helper has been effectively replaced with a more robust get_color() function that can identify many types of color inputs. A named color dictionary and rarity gradient dictionary has been added to constants to keep track of authentic colors. Expansion symbol info now processed in process_expansion_symbol_info, using helpers that take in a variety of data types and convert to authentic effects dictionaries. Old Expansion Symbol rendering can still be used by either changing the new Classic Symbol Rendering setting, or by enabling this setting within a custom template.
…hich in the future will help keep data in-line with what is expected for the layout object
…tend to NormalLayout

Also implemented new setting Render Miracle, when disabled miracle cards can render as any Normal template. Also deprecated default_class property from layouts, in favor of just using card_class and overwriting when necessary.
@davidianstyle
Copy link
Contributor Author

Rebased this branch with the latest code changes and tested to make sure that it doesn't break existing templates (as long as Color.Identity.Max = 2).

This update also includes 4 and 5 color frame support and includes a preview image using Jodah, the Unifier:
StainedGlassTemplate

Just a note that in order to use the 3, 4, and 5 color template features, user will need to change Color.Identity.Max to 3, 4, or 5. Since most templates support a max of 2 colors, this setting will need to be changed back to the default (2) to go back to generating proxies with other templates.

Open to any feedback or criticisms!

@davidianstyle
Copy link
Contributor Author

Also, reminder of where you can download the latest version of the Photoshop template file:
https://drive.google.com/file/d/1qczwwMJJHTOf-9pR3ymhlkKERY_47HH6/view?usp=share_link

@Investigamer
Copy link
Owner

Looking good, I will definitely fix conflicts after I finished merging in #70 and finally see about getting this PR merged as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants