-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace ip_round extension on Double for BinaryFloatingPoint #161
Open
MaxHasADHD
wants to merge
2
commits into
IntrepidPursuits:master
Choose a base branch
from
MaxHasADHD:max/BinaryFloatingPoint
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 18 additions & 0 deletions
18
SwiftWisdom/Core/StandardLibrary/Numbers/BinaryFloatingPoint+Extensions.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| // | ||
| // BinaryFloatingPoint+Extensions.swift | ||
| // SwiftWisdom | ||
| // | ||
| // Created by Stephen Wong on 5/1/16. | ||
| // Copyright © 2016 Intrepid. All rights reserved. | ||
| // | ||
|
|
||
| import Foundation | ||
|
|
||
| extension BinaryFloatingPoint { | ||
| // https://codereview.stackexchange.com/questions/142748/swift-floatingpoint-rounded-to-places | ||
MaxHasADHD marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| public func ip_round(toDecimalPlaces places: Int) -> Self { | ||
MaxHasADHD marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| guard places >= 0 else { return self } | ||
| let divisor = Self((0..<places).reduce(1.0) { (result, _) in result * 10.0 }) | ||
| return (self * divisor).rounded() / divisor | ||
| } | ||
| } | ||
18 changes: 0 additions & 18 deletions
18
SwiftWisdom/Core/StandardLibrary/Numbers/Double+Extensions.swift
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did this change? Did you re-run
pod installIf so, you could probably check in thePodfile.lockThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did run
pod installto generate the workspaceThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, since that made THIS change, didn't it also update
Podfile.lock? You should rerun it and check in the lock file if it changed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the lock file did not change.