SW – adding framework targets to SwiftWisdom.xcodeproj so that `IpS…
#159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wiftWisdom` and `RxIpSwiftWisdom` can be consumed via Carthage - Added build targets `IpSwiftWisdom` and `RxIpSwiftWisdom`. - Removed Pod references. - Added `Cartfile`. - Update .gitignore. - Wired up framework dependencies for all build targets. - Ensured that all existing targets build and that tests run. - Updated README
|
CI failed as expected? |
|
@Steven-Wu-ConnectedLab Hey! Nice to hear from you! This PR is not forgotten. We just need to get together and think about implications of using Carthage moving forward. We'll get back to you with some reviews/questions soon. Cheers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…wiftWisdom
andRxIpSwiftWisdom` can be consumed via CarthageDO NOTE MERGE YET
Changes
IpSwiftWisdomandRxIpSwiftWisdom.Cartfile.Dependent Work
This PR is dependent on IntrepidPursuits/uikit-wisdom#18 . After Ip-UI-Kit-Wisdom is consumable via Carthage, the
Cartfileon this repo will need to be updated to point to theIntrepidPursuits/uikit-wisdominstead.Notes
Podfileseem to mainly deal with Swift 4.2 migration which look to be complete now in0.11.0, so I did not make project or script changes to accommodate those custom build configurations.IpSwiftWisdomandRxIpSwiftWisdomto align with the repo name. May want to consider changing the podspec name to match since it means that folks who consume via Cocoapods are currently doingimport Intrepidas opposed toimport IpSwiftWisdom.Impact to Consumers
READMEto include Carthage consumption instructions.Impact to Contributors
Because CocoaPods touches the workspace & project file (Pods-project and build-phases), to allow consumption via Carthage, these had to be removed to avoid build errors. This means that contributors must contribute via Carthage going forward instead of Cocoapods. Notably,
pod install, one would docarthage bootstrap.Podfile, one would update theCartfileinstead.Impact to Workflows
These changes will likely break custom build/business workflows, or custom CI setups. I don't have any visibility into these workflows, so any feedback is appreciated.