CIP-0057: ContractBlueprint with derived schema definitions and safe schema refs #5824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unisay
force-pushed
the
yura/PLT-9657/derive-schema-types
branch
from
5ad7a0e to
b2bcbf9
Compare
Unisay
changed the title
|
I feel like I've lost the context again. Can we have a Note explaining what the deal is with nested types inside a schema and why we need to handle them in a special way? |
Unisay
force-pushed
the
yura/PLT-9657/derive-schema-types
branch
2 times, most recently
from
4605a2d to
961d455
Compare
Unisay
commented
Mar 11, 2024
Unisay
force-pushed
the
yura/PLT-9657/derive-schema-types
branch
from
961d455 to
c3b57a3
Compare
zliu41
reviewed
Mar 11, 2024
…initons. (#5839) * Add pointer to issue on the ledger's cost model interface (#5828) * Agda html (#5827) * Moved all Agda files to Markdown. * Added some brief text to the TOC * Fixed the file extension in Setup.hs for the Markdown Agda. * Added all possible file extensions and the preprocessor seems to run now. * Cleaned out .lagda from the cabal file, since everything is .lagda.md now. * chore(deps): bump tj-actions/changed-files from 42 to 43 (#5835) Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 42 to 43. - [Release notes](https://github.com/tj-actions/changed-files/releases) - [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md) - [Commits](tj-actions/changed-files@v42...v43) --- updated-dependencies: - dependency-name: tj-actions/changed-files dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Kwxm/correct conformance comments (#5829) * Fix comments in conformance tests * Fix comments in conformance tests * Fix comments in conformance tests * CIP-57: unroll top level types * Extract `goldenJson` function and move it to the `Tests.Lib` * Note about unrolling types * CIP-57: accumulate schema definitions preserving types for safe refs. * Build schema definitions by un-rolling a list of top-level types. * validatorParameters :: [] --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Kenneth MacKenzie <[email protected]> Co-authored-by: Ramsay Taylor <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Unisay
force-pushed
the
yura/PLT-9657/derive-schema-types
branch
from
c3b3cea to
210aa9e
Compare
* Derive validator blueprints, extend blueprint test to use 2 validators. * Compile typed validator * Example with 2 parameters * fail fast in case of duplicate annotations
Unisay
force-pushed
the
yura/PLT-9657/derive-schema-types
branch
from
210aa9e to
7755732
Compare
Unisay
changed the title
|
I am going to merge this PR as it contains pieces that were already reviewed in other PRs and merged here. I believe that I have addressed all the expressed concerns. If any concerns remain, though, I'd be happy to address them in next PRs. |
v0d1ch
pushed a commit
to v0d1ch/plutus
that referenced
this pull request
Dec 6, 2024
…schema refs (IntersectMBO#5824) CIP-0057: ContractBlueprint with derived schema definitions and safe schema refs (IntersectMBO#5824)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is that user specifies at most 3 types: Param, Datum, Redeemer and all the types nested withing them are extracted automatically (un-rolled).