This repository has been archived by the owner on Dec 2, 2024. It is now read-only.
Have plutus-ledger not depend on cardano-wallet-core #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid depending on cardano-wallet-core in plutus-ledger to make downstream consumption of only that package easier.
|
See this commit for an example of what dependencies we can avoid downstream: cardano-scaling/hydra@9bb2c52 |
|
LGTM, thanks @ch1bo :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid depending on cardano-wallet-core in
plutus-ledgerto make downstream consumption of only that package easier.This would help at least us over at https://github.com/input-output-hk/hydra-poc as we are not using anything else from
plutus-appsright now.Maybe this does not make sense as you will be adding more wallet-related things to
plutus-ledger.We may be able to refactor / vendor out the relevant usage of
plutus-ledgeralltogether.